From d89312022c01f2dd9e732cfd07eaa82afd2c0aa6 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Fri, 26 Apr 2024 14:51:53 -0400 Subject: [PATCH 01/11] meta: merge stalebot and update timings/messages --- .../workflows/close-stale-pull-requests.yml | 59 ------------------- .github/workflows/close-stale.yml | 52 ++++++++++++++++ 2 files changed, 52 insertions(+), 59 deletions(-) delete mode 100644 .github/workflows/close-stale-pull-requests.yml create mode 100644 .github/workflows/close-stale.yml diff --git a/.github/workflows/close-stale-pull-requests.yml b/.github/workflows/close-stale-pull-requests.yml deleted file mode 100644 index b18cd5c37e69c4..00000000000000 --- a/.github/workflows/close-stale-pull-requests.yml +++ /dev/null @@ -1,59 +0,0 @@ -name: Close stale pull requests -on: - workflow_dispatch: - inputs: - endDate: - description: stop processing PRs after this date - required: false - type: string - -# yamllint disable rule:empty-lines -env: - CLOSE_MESSAGE: > - This pull request was opened more than a year ago and there has - been no activity in the last 6 months. We value your contribution - but since it has not progressed in the last 6 months it is being - closed. If you feel closing this pull request is not the right thing - to do, please leave a comment. - - WARN_MESSAGE: > - This pull request was opened more than a year ago and there has - been no activity in the last 5 months. We value your contribution - but since it has not progressed in the last 5 months it is being - marked stale and will be closed if there is no progress in the - next month. If you feel that is not the right thing to do please - comment on the pull request. -# yamllint enable - -permissions: - contents: read - -jobs: - stale: - permissions: - pull-requests: write # for actions/stale to close stale PRs - if: github.repository == 'nodejs/node' - runs-on: ubuntu-latest - steps: - - name: Set default end date which is 1 year ago - run: echo "END_DATE=$(date --date='525600 minutes ago' --rfc-2822)" >> "$GITHUB_ENV" - - name: if date set in event override the default end date - env: - END_DATE_INPUT_VALUE: ${{ github.event.inputs.endDate }} - if: ${{ github.event.inputs.endDate != '' }} - run: echo "END_DATE=$END_DATE_INPUT_VALUE" >> "$GITHUB_ENV" - - uses: mhdawson/stale@453d6581568dc43dbe345757f24408d7b451c651 # PR to add support for endDate - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - end-date: ${{ env.END_DATE }} - days-before-issue-stale: -1 - days-before-issue-close: -1 - days-before-stale: 150 - days-before-close: 30 - stale-issue-label: stale - close-issue-message: ${{ env.CLOSE_MESSAGE }} - stale-issue-message: ${{ env.WARN_MESSAGE }} - exempt-pr-labels: never-stale - # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits - operations-per-run: 500 - remove-stale-when-updated: true diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml new file mode 100644 index 00000000000000..1c5e5fd311c7df --- /dev/null +++ b/.github/workflows/close-stale.yml @@ -0,0 +1,52 @@ +name: Close stale pull requests +on: + workflow_dispatch: + schedule: + # Run every day at 1:00 AM UTC. + - cron: 0 1 * * * +# yamllint disable rule:empty-lines +env: + CLOSE_MESSAGE: > + There hasn't been any activity on this issue/PR for over 8 months. + We appreciate your contribution, but since there hasn't been any + progress recently, we're closing it. If you disagree with this + decision, please leave a comment. + + WARN_MESSAGE: > + There hasn't been any activity on this issue/PR for over 8 months. + We appreciate your contribution, but since there hasn't been any + progress recently, we're closing it in **30 days**. If you + disagree with this decision, please leave a comment. +# yamllint enable + +permissions: + contents: read + issues: write + pull-requests: write + +jobs: + stale: + if: github.repository == 'nodejs/node' + runs-on: ubuntu-latest + steps: + - uses: actions/stale@v9.0.0 # PR to add support for endDate + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + + days-before-stale: 240 + days-before-close: 30 + + close-issue-message: ${{ env.CLOSE_MESSAGE }} + stale-issue-message: ${{ env.WARN_MESSAGE }} + + close-pr-message: ${{ env.CLOSE_MESSAGE }} + stale-pr-message: ${{ env.WARN_MESSAGE }} + + exempt-issue-labels: never-stale + exempt-pr-labels: never-stale + + stale-issue-label: stale + stale-pr-label: stale + + operations-per-run: 500 + remove-stale-when-updated: true From c392898057ad4d1338bf091f1315318e40e8973d Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Fri, 26 Apr 2024 14:52:39 -0400 Subject: [PATCH 02/11] meta: remove stalebot for feature-requests --- .../close-stale-feature-requests.yml | 56 ------------------- 1 file changed, 56 deletions(-) delete mode 100644 .github/workflows/close-stale-feature-requests.yml diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml deleted file mode 100644 index 301dbff620c602..00000000000000 --- a/.github/workflows/close-stale-feature-requests.yml +++ /dev/null @@ -1,56 +0,0 @@ -name: Close stale feature requests -on: - workflow_dispatch: - schedule: - # Run every day at 1:00 AM UTC. - - cron: 0 1 * * * - -# yamllint disable rule:empty-lines -env: - CLOSE_MESSAGE: > - There has been no activity on this feature request - and it is being closed. If you feel closing this issue is not the - right thing to do, please leave a comment. - - - For more information on how the project manages - feature requests, please consult the - [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md). - - WARN_MESSAGE: > - There has been no activity on this feature request for - 5 months. To help maintain relevant open issues, please - add the https://github.com/nodejs/node/labels/never-stale - label or close this issue if it should be closed. If not, - the issue will be automatically closed 6 months after the - last non-automated comment. - - For more information on how the project manages - feature requests, please consult the - [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md). -# yamllint enable - -permissions: - contents: read - -jobs: - stale: - permissions: - issues: write # for actions/stale to close stale issues - pull-requests: write # for actions/stale to close stale PRs - if: github.repository == 'nodejs/node' - runs-on: ubuntu-latest - steps: - - uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - days-before-stale: 180 - days-before-close: 30 - stale-issue-label: stale - close-issue-message: ${{ env.CLOSE_MESSAGE }} - stale-issue-message: ${{ env.WARN_MESSAGE }} - only-labels: feature request - exempt-issue-labels: never-stale - # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits - operations-per-run: 500 - remove-stale-when-updated: true From ec254f433a7df3f40e1070747b3ca54221353275 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Fri, 26 Apr 2024 14:59:13 -0400 Subject: [PATCH 03/11] meta: remove extra comments --- .github/workflows/close-stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index 1c5e5fd311c7df..78680e8e8a5133 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -29,7 +29,7 @@ jobs: if: github.repository == 'nodejs/node' runs-on: ubuntu-latest steps: - - uses: actions/stale@v9.0.0 # PR to add support for endDate + - uses: actions/stale@v9.0.0 with: repo-token: ${{ secrets.GITHUB_TOKEN }} From 5cab97222a37d3f7f635ec0388ed8a526b87b900 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Fri, 26 Apr 2024 15:03:24 -0400 Subject: [PATCH 04/11] meta: "happy linter, happy life" --- .github/workflows/close-stale.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index 78680e8e8a5133..13b690f19f9b0f 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -32,21 +32,15 @@ jobs: - uses: actions/stale@v9.0.0 with: repo-token: ${{ secrets.GITHUB_TOKEN }} - days-before-stale: 240 days-before-close: 30 - close-issue-message: ${{ env.CLOSE_MESSAGE }} stale-issue-message: ${{ env.WARN_MESSAGE }} - close-pr-message: ${{ env.CLOSE_MESSAGE }} stale-pr-message: ${{ env.WARN_MESSAGE }} - exempt-issue-labels: never-stale exempt-pr-labels: never-stale - stale-issue-label: stale stale-pr-label: stale - operations-per-run: 500 remove-stale-when-updated: true From 845f708002dca5a2c2b136a33a48c992228cba21 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Sat, 27 Apr 2024 12:41:56 -0400 Subject: [PATCH 05/11] Update .github/workflows/close-stale.yml Co-authored-by: Antoine du Hamel --- .github/workflows/close-stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index 13b690f19f9b0f..116c32c1509e0a 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -29,7 +29,7 @@ jobs: if: github.repository == 'nodejs/node' runs-on: ubuntu-latest steps: - - uses: actions/stale@v9.0.0 + - uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0 with: repo-token: ${{ secrets.GITHUB_TOKEN }} days-before-stale: 240 From 414e874763cdf88552c20f3bd123ccdf0b9172ff Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Sat, 27 Apr 2024 12:42:02 -0400 Subject: [PATCH 06/11] Update .github/workflows/close-stale.yml Co-authored-by: Antoine du Hamel --- .github/workflows/close-stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index 116c32c1509e0a..5ca87728f57362 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -13,7 +13,7 @@ env: decision, please leave a comment. WARN_MESSAGE: > - There hasn't been any activity on this issue/PR for over 8 months. + There hasn't been any activity on this issue/PR for over 7 months. We appreciate your contribution, but since there hasn't been any progress recently, we're closing it in **30 days**. If you disagree with this decision, please leave a comment. From c66a286b887a1374d77f06ac7597b8aab15e0e86 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 1 Jul 2024 19:15:41 -0400 Subject: [PATCH 07/11] Update feature-request-management.md --- .../feature-request-management.md | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/doc/contributing/feature-request-management.md b/doc/contributing/feature-request-management.md index 9331164314fb0e..8c84be02aab15a 100644 --- a/doc/contributing/feature-request-management.md +++ b/doc/contributing/feature-request-management.md @@ -52,38 +52,3 @@ support for that feature please express your support with the thumbs up emoji as a reaction. At some point in the future we may use this as additional input in the automated handling of feature requests. - -## Automated feature request handling - -Our experience is that most feature requests that are -likely to be addressed, will be addressed within the first -6 months after they are submitted. - -Once there has been no activity on a feature request for -5 months, the following comment will be added -to the issue: - -```markdown -There has been no activity on this feature request for -5 months and it is unlikely to be implemented. -It will be closed 6 months after the last non-automated comment. - -For more information on how the project manages -feature requests, please consult the -[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md). -``` - -If there is no additional activity/discussion on the -feature request in the next month, the following -comment is added to the issue and the issue will be -closed: - -```markdown -There has been no activity on this feature request -and it is being closed. If you feel closing this issue is not the -right thing to do, please leave a comment. - -For more information on how the project manages -feature requests, please consult the -[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md). -``` From 5bd4752a11fc30c024c52844869151927fae4305 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 1 Jul 2024 19:16:34 -0400 Subject: [PATCH 08/11] Update issues.md --- doc/contributing/issues.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/doc/contributing/issues.md b/doc/contributing/issues.md index 7cd043148ff000..9802b55dbf1210 100644 --- a/doc/contributing/issues.md +++ b/doc/contributing/issues.md @@ -60,5 +60,28 @@ activities, such as applying labels and closing/reopening/assigning issues. For more information on the roles and permissions, see ["Permission levels for repositories owned by an organization"](https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization). +## Handling stale issues + +Once there has been no activity on a issue for +7 months, the following comment will be added: + +```markdown +There hasn't been any activity on this issue/PR for over 7 months. +We appreciate your contribution, but since there hasn't been any +progress recently, we're closing it in **30 days**. If you +disagree with this decision, please leave a comment. +``` + +If there is no additional activity/discussion on the +issue in the next month (totalling to 8 months), it is +closed, and the following comment is added: + +```markdown +There hasn't been any activity on this issue/PR for over 8 months. +We appreciate your contribution, but since there hasn't been any +progress recently, we're closing it. If you disagree with this +decision, please leave a comment. +``` + [Node.js help repository]: https://github.com/nodejs/help/issues [Technical Steering Committee (TSC) repository]: https://github.com/nodejs/TSC/issues From c77a3436ad349ef0d859e71c337db3090c1f2dcc Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 10 Jul 2024 21:46:35 -0400 Subject: [PATCH 09/11] Allow caching --- .github/workflows/close-stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index 5ca87728f57362..c06d197733781e 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -20,7 +20,7 @@ env: # yamllint enable permissions: - contents: read + actions: write issues: write pull-requests: write From 7fe328057c45627b075aa48a50e0dab4aeb9e85d Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Thu, 8 Aug 2024 18:43:55 -0400 Subject: [PATCH 10/11] Update close-stale.yml --- .github/workflows/close-stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index c06d197733781e..f9a75b1da64829 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -1,4 +1,4 @@ -name: Close stale pull requests +name: Close stale issues and PRs on: workflow_dispatch: schedule: From e2b8b23ad365efa924597a9254472514b604b163 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Fri, 9 Aug 2024 10:13:52 -0400 Subject: [PATCH 11/11] Update close-stale.yml --- .github/workflows/close-stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale.yml b/.github/workflows/close-stale.yml index f9a75b1da64829..8991eea7908830 100644 --- a/.github/workflows/close-stale.yml +++ b/.github/workflows/close-stale.yml @@ -42,5 +42,5 @@ jobs: exempt-pr-labels: never-stale stale-issue-label: stale stale-pr-label: stale - operations-per-run: 500 + operations-per-run: 50 remove-stale-when-updated: true