From 603f07d1049c8c24788ff524a5e624998060fe52 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 3 May 2024 15:13:24 +0200 Subject: [PATCH 1/2] tools: fix V8 update workflow --- tools/dep_updaters/update-v8-patch.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/dep_updaters/update-v8-patch.sh b/tools/dep_updaters/update-v8-patch.sh index 799bf7697191b7..8c7c24620a4327 100755 --- a/tools/dep_updaters/update-v8-patch.sh +++ b/tools/dep_updaters/update-v8-patch.sh @@ -9,9 +9,9 @@ BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd) cd "$BASE_DIR" -IS_UP_TO_DATE=$(git node v8 minor | grep "V8 is up-to-date") +CAN_UPDATE=$(git node v8 minor --v8-dir /Users/duhamean/Documents/v8/v8/ | grep -q "V8 is up-to-date" || echo "1") -if [ -n "$IS_UP_TO_DATE" ]; then +if [ -z "$CAN_UPDATE" ]; then echo "Skipped because V8 is on the latest version." exit 0 fi From ad361760f068a530d9a7072c7199a03ca62f6d8c Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 3 May 2024 15:22:38 +0200 Subject: [PATCH 2/2] oops MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Michaël Zasso --- tools/dep_updaters/update-v8-patch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dep_updaters/update-v8-patch.sh b/tools/dep_updaters/update-v8-patch.sh index 8c7c24620a4327..77080f865154bc 100755 --- a/tools/dep_updaters/update-v8-patch.sh +++ b/tools/dep_updaters/update-v8-patch.sh @@ -9,7 +9,7 @@ BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd) cd "$BASE_DIR" -CAN_UPDATE=$(git node v8 minor --v8-dir /Users/duhamean/Documents/v8/v8/ | grep -q "V8 is up-to-date" || echo "1") +CAN_UPDATE=$(git node v8 minor | grep -q "V8 is up-to-date" || echo "1") if [ -z "$CAN_UPDATE" ]; then echo "Skipped because V8 is on the latest version."