From 3b86ea1fc34794d09102cc3995d56ec7ac540188 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 17 May 2024 20:15:37 -0700 Subject: [PATCH 1/3] doc: clarify possible `eventType` values in `fs.watch` --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index b485556a326fe3..03882e7fba46af 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -1774,7 +1774,7 @@ added: * `signal` {AbortSignal} An {AbortSignal} used to signal when the watcher should stop. * Returns: {AsyncIterator} of objects with the properties: - * `eventType` {string} The type of change + * `eventType` {'change'|'rename'} The type of change * `filename` {string|Buffer|null} The name of the file changed. Returns an async iterator that watches for changes on `filename`, where `filename` From 35bd8af1eaadfa900df7ff301c54ffc19e7ccee7 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 18 May 2024 07:10:45 -0700 Subject: [PATCH 2/3] Update fs.md --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 03882e7fba46af..494ecfa1fff6e3 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -1774,7 +1774,7 @@ added: * `signal` {AbortSignal} An {AbortSignal} used to signal when the watcher should stop. * Returns: {AsyncIterator} of objects with the properties: - * `eventType` {'change'|'rename'} The type of change + * `eventType` {'string'} The type of change: `'change'` or `'rename'` * `filename` {string|Buffer|null} The name of the file changed. Returns an async iterator that watches for changes on `filename`, where `filename` From e2251b36abf3d3a714b70e45d9e1ae1d90939ead Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 18 May 2024 07:12:07 -0700 Subject: [PATCH 3/3] Update fs.md --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 494ecfa1fff6e3..b19deeb9807302 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -1774,7 +1774,7 @@ added: * `signal` {AbortSignal} An {AbortSignal} used to signal when the watcher should stop. * Returns: {AsyncIterator} of objects with the properties: - * `eventType` {'string'} The type of change: `'change'` or `'rename'` + * `eventType` {string} The type of change: `'change'` or `'rename'` * `filename` {string|Buffer|null} The name of the file changed. Returns an async iterator that watches for changes on `filename`, where `filename`