From 191c248428e69fd657bbce6922891b34965efc02 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Thu, 6 Jun 2024 12:52:10 -0400 Subject: [PATCH 1/3] test: improve coverage for timer promises schedular --- test/parallel/test-timers-promises-scheduler.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/parallel/test-timers-promises-scheduler.js b/test/parallel/test-timers-promises-scheduler.js index 7caf92fdf6a74d..0298d8195d8334 100644 --- a/test/parallel/test-timers-promises-scheduler.js +++ b/test/parallel/test-timers-promises-scheduler.js @@ -48,3 +48,7 @@ async function testCancelableWait2() { } testCancelableWait2().then(common.mustCall()); + +throws(() => new scheduler.constructor()); +throws(() => new scheduler.constructor.prototype.yield()); +throws(() => new scheduler.constructor.prototype.wait()); From 93bb0708b10402a91d47136058fc2cb2ca1b887e Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:16:00 -0400 Subject: [PATCH 2/3] Update test-timers-promises-scheduler.js --- test/parallel/test-timers-promises-scheduler.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-timers-promises-scheduler.js b/test/parallel/test-timers-promises-scheduler.js index 0298d8195d8334..39acf8adb75bc9 100644 --- a/test/parallel/test-timers-promises-scheduler.js +++ b/test/parallel/test-timers-promises-scheduler.js @@ -7,6 +7,7 @@ const { setTimeout } = require('timers'); const { strictEqual, rejects, + throws, } = require('assert'); async function testYield() { @@ -49,6 +50,7 @@ async function testCancelableWait2() { testCancelableWait2().then(common.mustCall()); -throws(() => new scheduler.constructor()); -throws(() => new scheduler.constructor.prototype.yield()); -throws(() => new scheduler.constructor.prototype.wait()); +throws(() => new scheduler.constructor(), { + code: 'ERR_ILLEGAL_CONSTRUCTOR', +}); + From 9848c678e08efdc98e12591c5e2725011d277f0b Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:19:04 -0400 Subject: [PATCH 3/3] Update test-timers-promises-scheduler.js --- test/parallel/test-timers-promises-scheduler.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-timers-promises-scheduler.js b/test/parallel/test-timers-promises-scheduler.js index 39acf8adb75bc9..4eda43586f6c1d 100644 --- a/test/parallel/test-timers-promises-scheduler.js +++ b/test/parallel/test-timers-promises-scheduler.js @@ -53,4 +53,3 @@ testCancelableWait2().then(common.mustCall()); throws(() => new scheduler.constructor(), { code: 'ERR_ILLEGAL_CONSTRUCTOR', }); -