From 309febd5f3b0b30c412a3ee9790903aea2dd1ed8 Mon Sep 17 00:00:00 2001 From: Deokjin Kim Date: Sat, 8 Jun 2024 23:38:03 +0900 Subject: [PATCH 1/2] lib: fix naming convention of `Symbol` `node.js` prefix is used for global symbol(`Symbol.for`). So remove `node.js` prefix from `Symbol` usage. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring --- lib/internal/event_target.js | 2 +- lib/internal/events/symbols.js | 2 +- lib/internal/http2/util.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js index 1c7fd9dedb4878..dcdc3f528d03b5 100644 --- a/lib/internal/event_target.js +++ b/lib/internal/event_target.js @@ -65,7 +65,7 @@ const kWeakHandler = Symbol('kWeak'); const kResistStopPropagation = Symbol('kResistStopPropagation'); const kHybridDispatch = SymbolFor('nodejs.internal.kHybridDispatch'); -const kRemoveWeakListenerHelper = Symbol('nodejs.internal.removeWeakListenerHelper'); +const kRemoveWeakListenerHelper = Symbol('removeWeakListenerHelper'); const kCreateEvent = Symbol('kCreateEvent'); const kNewListener = Symbol('kNewListener'); const kRemoveListener = Symbol('kRemoveListener'); diff --git a/lib/internal/events/symbols.js b/lib/internal/events/symbols.js index b1b89ddb8f0a4d..fb0da6e96f119f 100644 --- a/lib/internal/events/symbols.js +++ b/lib/internal/events/symbols.js @@ -4,7 +4,7 @@ const { Symbol, } = primordials; -const kFirstEventParam = Symbol('nodejs.kFirstEventParam'); +const kFirstEventParam = Symbol('kFirstEventParam'); module.exports = { kFirstEventParam, diff --git a/lib/internal/http2/util.js b/lib/internal/http2/util.js index 4b0cc941a5e078..46e0218ac64f2e 100644 --- a/lib/internal/http2/util.js +++ b/lib/internal/http2/util.js @@ -34,7 +34,7 @@ const { kIsNodeError, } = require('internal/errors'); -const kSensitiveHeaders = Symbol('nodejs.http2.sensitiveHeaders'); +const kSensitiveHeaders = Symbol('sensitiveHeaders'); const kSocket = Symbol('socket'); const kProxySocket = Symbol('proxySocket'); const kRequest = Symbol('request'); From 0883a7e061844e58e53d5d59317ba56cb0d5f473 Mon Sep 17 00:00:00 2001 From: Deokjin Kim Date: Sun, 9 Jun 2024 09:00:14 +0900 Subject: [PATCH 2/2] Update lib/internal/event_target.js Co-authored-by: Luigi Pinca --- lib/internal/event_target.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js index dcdc3f528d03b5..ecdc1bbba054a3 100644 --- a/lib/internal/event_target.js +++ b/lib/internal/event_target.js @@ -65,7 +65,7 @@ const kWeakHandler = Symbol('kWeak'); const kResistStopPropagation = Symbol('kResistStopPropagation'); const kHybridDispatch = SymbolFor('nodejs.internal.kHybridDispatch'); -const kRemoveWeakListenerHelper = Symbol('removeWeakListenerHelper'); +const kRemoveWeakListenerHelper = Symbol('kRemoveWeakListenerHelper'); const kCreateEvent = Symbol('kCreateEvent'); const kNewListener = Symbol('kNewListener'); const kRemoveListener = Symbol('kRemoveListener');