From 8f9d0238e277370ebebcd8f92317f9e4662e0389 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 17 Jun 2024 14:51:06 -0500 Subject: [PATCH 1/7] meta: require TSC approval on certain changes --- .github/workflows/tsc-ping.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/workflows/tsc-ping.yml diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml new file mode 100644 index 00000000000000..21c7f6b1122fd4 --- /dev/null +++ b/.github/workflows/tsc-ping.yml @@ -0,0 +1,21 @@ +on: + pull_request_target: + paths: + - "deps/**" + +jobs: + ping-tsc: + runs-on: ubuntu-latest + name: Ping the TSC + if: github.event.pull_request.user.login != 'nodejs-github-bot' # Check if user is not the bot + steps: + - uses: marocchino/sticky-pull-request-comment@v2 + with: + number: ${{ github.event.pull_request.number }} + message: | + This PR modifies a directory typically controlled by automation. + @nodejs/tsc should review this change before anything + can be merged. - name: add label + - uses: actions-ecosystem/action-add-labels@v1 + with: + labels: blocked From 08871841c4c9b75dd7e89f773020102f4bc445a3 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 17 Jun 2024 14:52:14 -0500 Subject: [PATCH 2/7] Update tsc-ping.yml --- .github/workflows/tsc-ping.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml index 21c7f6b1122fd4..a29219430ccd2c 100644 --- a/.github/workflows/tsc-ping.yml +++ b/.github/workflows/tsc-ping.yml @@ -13,9 +13,9 @@ jobs: with: number: ${{ github.event.pull_request.number }} message: | - This PR modifies a directory typically controlled by automation. + This PR modifies a directory typically controlled by @nodejs/tsc should review this change before anything - can be merged. - name: add label + can be merged. - uses: actions-ecosystem/action-add-labels@v1 with: labels: blocked From 40b1b624fae3eb1c435f074f88ec6000077a3cf4 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 17 Jun 2024 14:59:18 -0500 Subject: [PATCH 3/7] Update tsc-ping.yml --- .github/workflows/tsc-ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml index a29219430ccd2c..df359fb73a717b 100644 --- a/.github/workflows/tsc-ping.yml +++ b/.github/workflows/tsc-ping.yml @@ -1,7 +1,7 @@ on: pull_request_target: paths: - - "deps/**" + - deps/** jobs: ping-tsc: From 337ff7f1169b4bed4ff5f6037361b2ed3db76d11 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 17 Jun 2024 15:00:10 -0500 Subject: [PATCH 4/7] Update tsc-ping.yml --- .github/workflows/tsc-ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml index df359fb73a717b..de93e6626df525 100644 --- a/.github/workflows/tsc-ping.yml +++ b/.github/workflows/tsc-ping.yml @@ -13,7 +13,7 @@ jobs: with: number: ${{ github.event.pull_request.number }} message: | - This PR modifies a directory typically controlled by + This PR modifies a directory typically controlled by @nodejs/tsc should review this change before anything can be merged. - uses: actions-ecosystem/action-add-labels@v1 From 44d22c4078044e45c0a56bdd87072d70d026eb69 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 17 Jun 2024 16:19:54 -0500 Subject: [PATCH 5/7] Update tsc-ping.yml Co-authored-by: Antoine du Hamel --- .github/workflows/tsc-ping.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml index de93e6626df525..be36f2f78fb834 100644 --- a/.github/workflows/tsc-ping.yml +++ b/.github/workflows/tsc-ping.yml @@ -13,9 +13,7 @@ jobs: with: number: ${{ github.event.pull_request.number }} message: | - This PR modifies a directory typically controlled by - @nodejs/tsc should review this change before anything - can be merged. + /cc @nodejs/tsc - uses: actions-ecosystem/action-add-labels@v1 with: labels: blocked From c890c3a99d147a81330b3ae6d2a6ed3a0bbd4612 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Mon, 17 Jun 2024 16:24:18 -0500 Subject: [PATCH 6/7] Update tsc-ping.yml --- .github/workflows/tsc-ping.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml index be36f2f78fb834..28c63a38ee447e 100644 --- a/.github/workflows/tsc-ping.yml +++ b/.github/workflows/tsc-ping.yml @@ -3,17 +3,21 @@ on: paths: - deps/** +permissions: + pull-requests: write + issues: write + jobs: ping-tsc: runs-on: ubuntu-latest name: Ping the TSC if: github.event.pull_request.user.login != 'nodejs-github-bot' # Check if user is not the bot steps: - - uses: marocchino/sticky-pull-request-comment@v2 + - uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2.9.0 with: number: ${{ github.event.pull_request.number }} message: | /cc @nodejs/tsc - - uses: actions-ecosystem/action-add-labels@v1 + - uses: actions-ecosystem/action-add-labels@f146b04613e5d5b57ff227cba3db0954551fbc6a # v1.1.0 with: labels: blocked From 581c7be96df6398c80e28add5cfe88076392bdb1 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Thu, 20 Jun 2024 12:10:23 -0500 Subject: [PATCH 7/7] Update tsc-ping.yml --- .github/workflows/tsc-ping.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/tsc-ping.yml b/.github/workflows/tsc-ping.yml index 28c63a38ee447e..2ada2479ca382d 100644 --- a/.github/workflows/tsc-ping.yml +++ b/.github/workflows/tsc-ping.yml @@ -8,16 +8,17 @@ permissions: issues: write jobs: - ping-tsc: + add-comment: runs-on: ubuntu-latest - name: Ping the TSC + name: Add comment when a PR modifies a automation-controlled directory if: github.event.pull_request.user.login != 'nodejs-github-bot' # Check if user is not the bot steps: - uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2.9.0 with: number: ${{ github.event.pull_request.number }} message: | - /cc @nodejs/tsc - - uses: actions-ecosystem/action-add-labels@f146b04613e5d5b57ff227cba3db0954551fbc6a # v1.1.0 - with: - labels: blocked + This pull request appears to be modifying a file within a + directory that is typically controlled by automation. + + Please carefully review and follow the [Collaborator Guide](https://github.com/nodejs/node/blob/HEAD/doc/contributing/collaborator-guide.md#code-reviews) + before approving this pull request.