From a1d2cee08c79eea14225c56dc0364b75484117f3 Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Wed, 19 Mar 2025 00:00:47 +0000 Subject: [PATCH 1/5] doc: add section stating that very stale PRs should be closed --- doc/contributing/pull-requests.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 201b59f4923910..a4616219c28aff 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -446,6 +446,17 @@ credit for the work they started (either by preserving their name and email address) in the commit log, or by using an `Author:` meta-data tag in the commit. +If a pull request has been inactive for more than six months, it is unlikely +to be merged. The contributor may no longer be engaged, may have lost context +on their changes, the Node.js codebase may have evolved to the point where +resuming the effort is impractical, or all of the above. +To keep the project well organized and more maintainable, such stale pull +requests should generally be closed unless they provide clear ongoing value +or have a well defined path forward. When closing a pull request, always +leave a polite comment explaining the reason and encouraging the contributor +to restart the effort and submit a new pull request if the changes are still +relevant or valuable. + ### Approving a change Any Node.js core collaborator (any GitHub user with commit rights in the From a7f31c30aba9e5a176fa97daf8d9f2a912c13b51 Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Wed, 19 Mar 2025 00:16:39 +0000 Subject: [PATCH 2/5] Update doc/contributing/pull-requests.md Co-authored-by: Yagiz Nizipli --- doc/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index a4616219c28aff..02c8083345b6a0 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -455,7 +455,7 @@ requests should generally be closed unless they provide clear ongoing value or have a well defined path forward. When closing a pull request, always leave a polite comment explaining the reason and encouraging the contributor to restart the effort and submit a new pull request if the changes are still -relevant or valuable. +relevant and applicable. ### Approving a change From a5f4e3fac44f8dbc4813d8d5457f8fdc29684817 Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Wed, 19 Mar 2025 11:08:14 +0000 Subject: [PATCH 3/5] Update doc/contributing/pull-requests.md Co-authored-by: Antoine du Hamel --- doc/contributing/pull-requests.md | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 02c8083345b6a0..87869c94adb4fe 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -446,16 +446,10 @@ credit for the work they started (either by preserving their name and email address) in the commit log, or by using an `Author:` meta-data tag in the commit. -If a pull request has been inactive for more than six months, it is unlikely -to be merged. The contributor may no longer be engaged, may have lost context -on their changes, the Node.js codebase may have evolved to the point where -resuming the effort is impractical, or all of the above. -To keep the project well organized and more maintainable, such stale pull -requests should generally be closed unless they provide clear ongoing value -or have a well defined path forward. When closing a pull request, always -leave a polite comment explaining the reason and encouraging the contributor -to restart the effort and submit a new pull request if the changes are still -relevant and applicable. +If a pull request has been inactive for more than six months, add the `stalled` label +to it. That should trigger an automation that adds a comment explaining the pull request +may be close for inactivity, giving a heads-up to the contributor before actually +close it if is still inactive. ### Approving a change From cd80b9867a716de9fdbdeaab5d7d5c3373e71708 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 24 Mar 2025 17:16:51 -0700 Subject: [PATCH 4/5] Update doc/contributing/pull-requests.md --- doc/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 87869c94adb4fe..944b9269c8f001 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -449,7 +449,7 @@ commit. If a pull request has been inactive for more than six months, add the `stalled` label to it. That should trigger an automation that adds a comment explaining the pull request may be close for inactivity, giving a heads-up to the contributor before actually -close it if is still inactive. +closing it if it remains inactive. ### Approving a change From 1918451f65b15d068842a850ad2eb38478227434 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 24 Mar 2025 17:17:00 -0700 Subject: [PATCH 5/5] Update doc/contributing/pull-requests.md --- doc/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 944b9269c8f001..b2556577536791 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -447,7 +447,7 @@ address) in the commit log, or by using an `Author:` meta-data tag in the commit. If a pull request has been inactive for more than six months, add the `stalled` label -to it. That should trigger an automation that adds a comment explaining the pull request +to it. That will trigger an automation that adds a comment explaining the pull request may be close for inactivity, giving a heads-up to the contributor before actually closing it if it remains inactive.