From 1a14beb70f51d89919435a2f9ea4d8cc88565183 Mon Sep 17 00:00:00 2001 From: Franziska Hinkelmann Date: Fri, 27 May 2016 17:59:06 +0200 Subject: [PATCH] deps: upgrade V8 from 5.1.281.49 to 5.1.281.51 This patch brings in @indutny's fix for tickprocessor Cpp symbols on mac into V8 5.1. So `make test` is green again on MacOS. --- deps/v8/include/v8-version.h | 2 +- deps/v8/src/typing-asm.cc | 2 -- deps/v8/tools/tickprocessor.js | 5 ++++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h index 949ae708cf9221..f192295f56949b 100644 --- a/deps/v8/include/v8-version.h +++ b/deps/v8/include/v8-version.h @@ -11,7 +11,7 @@ #define V8_MAJOR_VERSION 5 #define V8_MINOR_VERSION 1 #define V8_BUILD_NUMBER 281 -#define V8_PATCH_LEVEL 49 +#define V8_PATCH_LEVEL 51 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/deps/v8/src/typing-asm.cc b/deps/v8/src/typing-asm.cc index 942b57b66b72ea..7482c4f65191db 100644 --- a/deps/v8/src/typing-asm.cc +++ b/deps/v8/src/typing-asm.cc @@ -1553,8 +1553,6 @@ AsmTyper::VariableInfo* AsmTyper::GetVariableInfo(Variable* variable, if (!entry && in_function_) { entry = global_variable_type_.Lookup(variable, ComputePointerHash(variable)); - if (entry && entry->value) { - } } } if (!entry) return NULL; diff --git a/deps/v8/tools/tickprocessor.js b/deps/v8/tools/tickprocessor.js index 7d07bf6c558a37..ba7401a2236dd3 100644 --- a/deps/v8/tools/tickprocessor.js +++ b/deps/v8/tools/tickprocessor.js @@ -670,8 +670,11 @@ inherits(MacCppEntriesProvider, UnixCppEntriesProvider); MacCppEntriesProvider.prototype.loadSymbols = function(libName) { this.parsePos = 0; libName = this.targetRootFS + libName; + + // It seems that in OS X `nm` thinks that `-f` is a format option, not a + // "flat" display option flag. try { - this.symbols = [os.system(this.nmExec, ['-n', '-f', libName], -1, -1), '']; + this.symbols = [os.system(this.nmExec, ['-n', libName], -1, -1), '']; } catch (e) { // If the library cannot be found on this system let's not panic. this.symbols = '';