From 28434f6b4ec88ef8aa16172ebbf5896c9e2acf62 Mon Sep 17 00:00:00 2001 From: Pavol Otcenas Date: Sat, 17 Sep 2016 11:16:03 +0200 Subject: [PATCH 1/2] test: modernize JS and tighten equality checking Changed var -> const and assert.equal -> assert.strictEqual --- test/parallel/test-eval.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-eval.js b/test/parallel/test-eval.js index 98514af5be40be..4cd483703f0c34 100644 --- a/test/parallel/test-eval.js +++ b/test/parallel/test-eval.js @@ -1,13 +1,13 @@ 'use strict'; const common = require('../common'); -var util = require('util'); -var assert = require('assert'); -var exec = require('child_process').exec; +const util = require('util'); +const assert = require('assert'); +const exec = require('child_process').exec; -var cmd = ['"' + process.execPath + '"', '-e', '"console.error(process.argv)"', +const cmd = ['"' + process.execPath + '"', '-e', '"console.error(process.argv)"', 'foo', 'bar'].join(' '); -var expected = util.format([process.execPath, 'foo', 'bar']) + '\n'; +const expected = util.format([process.execPath, 'foo', 'bar']) + '\n'; exec(cmd, common.mustCall(function(err, stdout, stderr) { assert.ifError(err); - assert.equal(stderr, expected); + assert.strictEqual(stderr, expected); })); From 88905ed315bec5d6bfb39981b5944c10993879fb Mon Sep 17 00:00:00 2001 From: Pavol Otcenas Date: Sat, 17 Sep 2016 11:55:25 +0200 Subject: [PATCH 2/2] test: fixed long line in test-eval.js Wrapped line longer than 80 chars to more lines. --- test/parallel/test-eval.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-eval.js b/test/parallel/test-eval.js index 4cd483703f0c34..b27aa33d84275c 100644 --- a/test/parallel/test-eval.js +++ b/test/parallel/test-eval.js @@ -4,8 +4,8 @@ const util = require('util'); const assert = require('assert'); const exec = require('child_process').exec; -const cmd = ['"' + process.execPath + '"', '-e', '"console.error(process.argv)"', - 'foo', 'bar'].join(' '); +const cmd = ['"' + process.execPath + '"', '-e', + '"console.error(process.argv)"', 'foo', 'bar'].join(' '); const expected = util.format([process.execPath, 'foo', 'bar']) + '\n'; exec(cmd, common.mustCall(function(err, stdout, stderr) { assert.ifError(err);