build: Don't throw when 'releases' is undefined (#1624)

fhemberger · web-flow · commit c4a540b34916 · 2018-04-08T15:06:29.000+02:00
In case `versions.json` could not be properly downloaded/parsed by 'node-version-data', avoid `TypeError: Cannot read property 'find' of undefined` when `releases` is `undefined` and return `undefined` instead. Error should be handled properly elsewhere. See: #1618
diff --git a/scripts/helpers/latestversion.js b/scripts/helpers/latestversion.js
@@ -11,11 +11,11 @@ const map = (release) => release && {
 }
 
 exports.current = (releases) => {
-  const match = releases.find((release) => !release.lts && semver.gte(release.version, '5.0.0'))
+  const match = releases && releases.find((release) => !release.lts && semver.gte(release.version, '5.0.0'))
   return map(match)
 }
 
-exports.lts = (releases) => map(releases.find((release) => release.lts))
+exports.lts = (releases) => map(releases && releases.find((release) => release.lts))
 
 function majorStr (release) {
   return `v${semver.major(release.version)}.x`

Original file line number	Diff line number	Diff line change
`@@ -11,11 +11,11 @@ const map = (release) => release && {`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`exports.current = (releases) => {`
`14`		`- const match = releases.find((release) => !release.lts && semver.gte(release.version, '5.0.0'))`
	`14`	`+ const match = releases && releases.find((release) => !release.lts && semver.gte(release.version, '5.0.0'))`
`15`	`15`	`return map(match)`
`16`	`16`	`}`
`17`	`17`
`18`		`-exports.lts = (releases) => map(releases.find((release) => release.lts))`
	`18`	`+exports.lts = (releases) => map(releases && releases.find((release) => release.lts))`
`19`	`19`
`20`	`20`	`function majorStr (release) {`
`21`	`21`	return `v${semver.major(release.version)}.x`