From 73f7e0eedc98af1531a42ceee301390d199d858c Mon Sep 17 00:00:00 2001 From: Max Ogden Date: Tue, 15 Sep 2015 14:51:00 -0700 Subject: [PATCH 1/3] add NODE_MODULE_VERSION column to the releases table --- layouts/download-releases.hbs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/layouts/download-releases.hbs b/layouts/download-releases.hbs index a77700647d72d..bd5f737edc78e 100644 --- a/layouts/download-releases.hbs +++ b/layouts/download-releases.hbs @@ -25,6 +25,7 @@ Date V8 npm + NODE_MODULE_VERSION @@ -35,6 +36,7 @@ {{v8}} {{npm}} + {{modules}} {{i18n 'releases.downloads'}} From 8a52c5dc19e85fa1a81eecfd3149fb5652e3e7d4 Mon Sep 17 00:00:00 2001 From: Max Ogden Date: Sat, 19 Sep 2015 09:47:09 -0700 Subject: [PATCH 2/3] rename column to modules and put description in footer --- layouts/css/page-modules/_download.styl | 3 +++ layouts/download-releases.hbs | 5 +++-- locale/en/download/releases.md | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/layouts/css/page-modules/_download.styl b/layouts/css/page-modules/_download.styl index de792d66032f2..618b9f0a355eb 100644 --- a/layouts/css/page-modules/_download.styl +++ b/layouts/css/page-modules/_download.styl @@ -74,6 +74,9 @@ td.download-table-last > a padding 0 10px +#modules-description + font-size: small + @media (max-width: 700px) .download-hero ul width auto diff --git a/layouts/download-releases.hbs b/layouts/download-releases.hbs index bd5f737edc78e..806894c57c0c7 100644 --- a/layouts/download-releases.hbs +++ b/layouts/download-releases.hbs @@ -25,7 +25,7 @@ Date V8 npm - NODE_MODULE_VERSION + Modules @@ -36,7 +36,7 @@ {{v8}} {{npm}} - {{modules}} + {{modules}} {{i18n 'releases.downloads'}} @@ -49,6 +49,7 @@ {{/project.versions}} +

{{modules}}

diff --git a/locale/en/download/releases.md b/locale/en/download/releases.md index a8b55ce401a45..8d52c1b318ad1 100644 --- a/locale/en/download/releases.md +++ b/locale/en/download/releases.md @@ -3,4 +3,5 @@ layout: download-releases.hbs title: Previous Releases iojs: intro: "Releases 1.x through 3.x were called \"io.js\" as they were part of the io.js fork. As of Node.js 4.0.0 the former release lines of io.js converged with Node.js 0.12.x into unified Node.js releases." +modules: "\"Modules\" refers to the ABI (application binary interface) version number of Node.js, used to determine which versions of Node.js compiled C++ add-on binaries can be loaded in to without needing to be re-compiled. This version number is also referred to as NODE_MODULE_VERSION." --- From 0e54e7340d8622f5925b3e25623ec62b84b304f0 Mon Sep 17 00:00:00 2001 From: Max Ogden Date: Sat, 19 Sep 2015 11:27:17 -0700 Subject: [PATCH 3/3] wrap in code block --- layouts/download-releases.hbs | 2 +- locale/en/download/releases.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/layouts/download-releases.hbs b/layouts/download-releases.hbs index 806894c57c0c7..45422eabf07f3 100644 --- a/layouts/download-releases.hbs +++ b/layouts/download-releases.hbs @@ -49,7 +49,7 @@ {{/project.versions}} -

{{modules}}

+

{{{modules}}}

diff --git a/locale/en/download/releases.md b/locale/en/download/releases.md index 8d52c1b318ad1..d30764f310e7c 100644 --- a/locale/en/download/releases.md +++ b/locale/en/download/releases.md @@ -3,5 +3,5 @@ layout: download-releases.hbs title: Previous Releases iojs: intro: "Releases 1.x through 3.x were called \"io.js\" as they were part of the io.js fork. As of Node.js 4.0.0 the former release lines of io.js converged with Node.js 0.12.x into unified Node.js releases." -modules: "\"Modules\" refers to the ABI (application binary interface) version number of Node.js, used to determine which versions of Node.js compiled C++ add-on binaries can be loaded in to without needing to be re-compiled. This version number is also referred to as NODE_MODULE_VERSION." +modules: "\"Modules\" refers to the ABI (application binary interface) version number of Node.js, used to determine which versions of Node.js compiled C++ add-on binaries can be loaded in to without needing to be re-compiled. This version number is also referred to as NODE_MODULE_VERSION." ---