From 9474533aad747c663a1e5e564425406293443980 Mon Sep 17 00:00:00 2001
From: DongWei <maledong_public@foxmail.com>
Date: Sat, 8 Oct 2022 09:55:17 +0800
Subject: [PATCH] remove useless js snippets of codes for "Edit On GitHub"

We don't need to implement it through the client side but serve side
only by generating them together.

Refs: https://github.com/nodejs/nodejs.org/pull/4315.
---
 build.js                       |  2 +-
 layouts/partials/footer.hbs    |  6 ++----
 scripts/plugins/githubLinks.js | 16 ++++++++++++----
 static/js/main.js              | 19 -------------------
 4 files changed, 15 insertions(+), 28 deletions(-)

diff --git a/build.js b/build.js
index 909132bfbe188..e419eb2698366 100755
--- a/build.js
+++ b/build.js
@@ -159,7 +159,6 @@ function buildLocale(source, locale, opts) {
       })
     )
     .use(markdown(markedOptions))
-    .use(githubLinks({ locale, site: i18nJSON(locale) }))
     // Set pretty permalinks, we don't want .html suffixes everywhere.
     .use(
       permalinks({
@@ -195,6 +194,7 @@ function buildLocale(source, locale, opts) {
     .use(hbsReg())
     .use(scriptReg())
     .use(layouts())
+    .use(githubLinks({ locale, site: i18nJSON(locale) }))
     // Pipes the generated files into their respective subdirectory in the build
     // directory.
     .destination(path.join(__dirname, 'build', locale))
diff --git a/layouts/partials/footer.hbs b/layouts/partials/footer.hbs
index 5f42d3d35b9ff..e71fec27d4f6e 100644
--- a/layouts/partials/footer.hbs
+++ b/layouts/partials/footer.hbs
@@ -14,10 +14,8 @@
         <a href="https://trademark-policy.openjsf.org">Trademark Policy</a> | 
         <a href="https://trademark-list.openjsf.org">Trademark List</a> | 
         <a href="https://www.linuxfoundation.org/cookies">Cookie Policy</a>
-        </p>
-        <div class="openjsfoundation-footer-edit">
-             | <a id="editOnGitHubLink" href="#">{{site.editOnGithub}}</a>
-        </div>
+      </p>
+        <div class="openjsfoundation-footer-edit"></div>
     </div>
   </div>
 
diff --git a/scripts/plugins/githubLinks.js b/scripts/plugins/githubLinks.js
index 53d4d07525949..33a501b501547 100644
--- a/scripts/plugins/githubLinks.js
+++ b/scripts/plugins/githubLinks.js
@@ -17,10 +17,18 @@ function githubLinks(options) {
       const file = files[path];
       path = path.replace('.html', '.md').replace(/\\/g, '/');
       const url = `https://github.com/nodejs/nodejs.org/edit/main/locale/${options.locale}/${path}`;
-
-      const contents =
-        file.contents.toString() +
-        ` <input type = "hidden" id = "editOnGitHubUrl" value="${url}"/> `;
+      const editOnGitHubTrans = options.site.editOnGithub || 'Edit on GitHub';
+      const replCallBack = (match, $1, $2) => {
+        return `<div class="openjsfoundation-footer-edit">
+            | <a href="${url}">${editOnGitHubTrans}</a>
+            </div>`;
+      };
+      const contents = file.contents
+        .toString()
+        .replace(
+          /<div class="openjsfoundation-footer-edit"><\/div>/,
+          replCallBack
+        );
 
       file.contents = Buffer.from(contents);
     });
diff --git a/static/js/main.js b/static/js/main.js
index 2798987780274..7bc626fae8382 100644
--- a/static/js/main.js
+++ b/static/js/main.js
@@ -159,22 +159,3 @@
     winText.textContent = winText.textContent.replace(/x(86|64)/, arch);
   }
 })();
-(function () {
-  // This function is used to replace the anchor
-  // link of Edit on GitHub
-
-  var editOnGitHubElement = document.getElementById('editOnGitHubLink');
-  var editOnGitHubUrlElement = document.getElementById('editOnGitHubUrl');
-
-  if (!editOnGitHubElement) {
-    return;
-  }
-
-  if (editOnGitHubUrlElement) {
-    editOnGitHubElement.setAttribute('href', editOnGitHubUrlElement.value);
-  } else {
-    editOnGitHubElement.parentNode.parentNode.removeChild(
-      editOnGitHubElement.parentNode
-    );
-  }
-})();