From 10fc21f69a98ee8698574ad3708c419c119e265e Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Wed, 20 Aug 2025 11:25:54 -0700 Subject: [PATCH 1/2] chore: ensure npm@11 is installed for OIDC publishing Signed-off-by: Luke Karrys --- .github/workflows/publish-packages.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish-packages.yml b/.github/workflows/publish-packages.yml index dcccabed6b39c..25757051148d3 100644 --- a/.github/workflows/publish-packages.yml +++ b/.github/workflows/publish-packages.yml @@ -108,13 +108,17 @@ jobs: - name: Set up pnpm uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 - - name: Setup Node.js + - name: Set up Node.js uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 with: # Don't use caching here as we never install dependencies in this workflow node-version-file: '.nvmrc' registry-url: 'https://registry.npmjs.org' + - name: Setup npm + # OIDC requires npm >=11.5.1. pnpm will use the installed version of npm for publishing + run: npm install -g npm@11 + - name: Publish working-directory: packages/${{ matrix.package }} run: | From 76b456f8afe02c9abc0827fe1e78a08546d9b56f Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Wed, 20 Aug 2025 15:02:05 -0400 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Aviv Keller --- .github/workflows/publish-packages.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish-packages.yml b/.github/workflows/publish-packages.yml index 25757051148d3..3d35a9fe01da7 100644 --- a/.github/workflows/publish-packages.yml +++ b/.github/workflows/publish-packages.yml @@ -108,15 +108,16 @@ jobs: - name: Set up pnpm uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 - - name: Set up Node.js + - name: Setup Node.js uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 with: # Don't use caching here as we never install dependencies in this workflow node-version-file: '.nvmrc' registry-url: 'https://registry.npmjs.org' - - name: Setup npm - # OIDC requires npm >=11.5.1. pnpm will use the installed version of npm for publishing + - name: Re-install npm + # TODO: OIDC requires npm >=11.5.1. + # Until Node.js v24 is LTS (with npm 11 as the default), we need to bump. run: npm install -g npm@11 - name: Publish