Skip to content

Comments

docs: add the cleanup-test command#1227

Merged
yizha1 merged 6 commits intonotaryproject:mainfrom
yizha1:issue-647
Mar 21, 2025
Merged

docs: add the cleanup-test command#1227
yizha1 merged 6 commits intonotaryproject:mainfrom
yizha1:issue-647

Conversation

@yizha1
Copy link
Contributor

@yizha1 yizha1 commented Mar 17, 2025

Update the CLI spec to resolve #647

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from a user March 17, 2025 21:41
@yizha1 yizha1 requested a review from vaninrao10 as a code owner March 17, 2025 21:41
yizha1 added 2 commits March 17, 2025 14:42
Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
@yizha1
Copy link
Contributor Author

yizha1 commented Mar 17, 2025

@FeynmanZhou @Two-Hearts @JeyJeyGao @shizhMSFT please help to review this PR

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.54%. Comparing base (31de373) to head (491a8ed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   76.54%   76.54%           
=======================================
  Files          67       67           
  Lines        3710     3710           
=======================================
  Hits         2840     2840           
  Misses        671      671           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shizhMSFT shizhMSFT changed the title doc: add the cleanup-test command docs: add the cleanup-test command Mar 18, 2025
yizha1 added 2 commits March 19, 2025 11:21
Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from shizhMSFT March 20, 2025 20:51
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 784ffb8 into notaryproject:main Mar 21, 2025
7 checks passed
@yizha1 yizha1 deleted the issue-647 branch March 21, 2025 16:22
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Update the CLI spec to resolve notaryproject#647 

Signed-off-by: Yi Zha <yizha1@microsoft.com>

---------

Signed-off-by: Yi Zha (from Dev Box) <yizha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support clean up the source key and certificate generated by Notation

4 participants