Use cobra cli for docker-generate command#250
Conversation
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
|
Are we going to support docker plugin in notation? If not then we can get rid of |
SteveLasker
left a comment
There was a problem hiding this comment.
LGTM for the move to cobra.
|
@priteshbandi - I created a new discussion for dropping those commands. I believe it is a good thing to consider. I think we should not hold up this PR though on the outcome of the discussion. However @chloeyin I do think you should skip the |
Yes, I can skip the |
|
Since the plan from the discussion yesterday is to remove this and we have two code reviews/approvals from our side. I'm going to go ahead and merge it. |
Signed-off-by: zaihaoyin zaihaoyin@microsoft.com
What
Fix #183 by using
github.com/spf13/cobrato replacegithub.com/urfave/cli/v2, which is a cli package also used by oras-cli.Notice
The whole PR will update about 50 files, which is too difficult to review. I will split them into 4 PRs.
I expect these 4 PRs will do different jobs:
docker-generatecommand to usecobraand add some common flags whichcobrawill use in later PRs.docker-notationcommand to usecobra.notationcommand to usecobra.This is the first PR of the series.