Skip to content

feat: add support for notation inspect#556

Closed
byronchien wants to merge 1 commit intonotaryproject:mainfrom
byronchien:inspect
Closed

feat: add support for notation inspect#556
byronchien wants to merge 1 commit intonotaryproject:mainfrom
byronchien:inspect

Conversation

@byronchien
Copy link
Contributor

duplicate of notation #528

squashed changes to fix commit author and signature.

Signed-off-by: Byron Chien <byronc@ucla.edu>
@byronchien byronchien changed the title Add support for notation inspect feat: add support for notation inspect Feb 16, 2023
@byronchien byronchien marked this pull request as ready for review February 16, 2023 00:08
@codecov-commenter
Copy link

Codecov Report

Merging #556 (00896e4) into main (54b42cb) will decrease coverage by 1.98%.
The diff coverage is 21.16%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   36.34%   34.36%   -1.98%     
==========================================
  Files          30       32       +2     
  Lines        1607     1848     +241     
==========================================
+ Hits          584      635      +51     
- Misses       1002     1192     +190     
  Partials       21       21              
Impacted Files Coverage Δ
cmd/notation/main.go 0.00% <0.00%> (ø)
internal/envelope/envelope.go 25.92% <0.00%> (-74.08%) ⬇️
cmd/notation/inspect.go 14.21% <14.21%> (ø)
internal/tree/tree.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@priteshbandi priteshbandi requested review from gokarnm, priteshbandi and shizhMSFT and removed request for shizhMSFT February 16, 2023 00:39
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

Closing this as #556 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments