update: based on spec, updated messages of notation key command#684
Merged
priteshbandi merged 4 commits intomainfrom May 25, 2023
unknown repository
Merged
update: based on spec, updated messages of notation key command#684priteshbandi merged 4 commits intomainfrom unknown repository
priteshbandi merged 4 commits intomainfrom
unknown repository
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
SteveLasker,
gokarnm,
justincormack,
priteshbandi,
rgnote and
shizhMSFT
as code owners
ghost
self-assigned this
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #684 +/- ##
==========================================
+ Coverage 58.55% 63.94% +5.39%
==========================================
Files 40 40
Lines 2210 2219 +9
==========================================
+ Hits 1294 1419 +125
+ Misses 815 679 -136
- Partials 101 121 +20
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
reviewed
May 25, 2023
added 2 commits
May 25, 2023 16:42
6 tasks
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
…ryproject#684) This PR is based on spec changes in here: notaryproject#606. --------- Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
…ryproject#684) This PR is based on spec changes in here: notaryproject#606. --------- Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on spec changes in here: #606.