From ca016f5725d23acd5a09bf18a6aa1cd4f178db93 Mon Sep 17 00:00:00 2001
From: Austin Drenski <austin.drenski@gmail.com>
Date: Sat, 28 Jul 2018 12:10:40 -0400
Subject: [PATCH] Add doc comments and refactors from 541

---
 .../Internal/ArrayAnyAllExpression.cs            | 15 +++------------
 .../Internal/NpgsqlQuerySqlGeneratorFactory.cs   | 16 ++++++++++++----
 2 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/src/EFCore.PG/Query/Expressions/Internal/ArrayAnyAllExpression.cs b/src/EFCore.PG/Query/Expressions/Internal/ArrayAnyAllExpression.cs
index a5ea6b89d..f7d15efc9 100644
--- a/src/EFCore.PG/Query/Expressions/Internal/ArrayAnyAllExpression.cs
+++ b/src/EFCore.PG/Query/Expressions/Internal/ArrayAnyAllExpression.cs
@@ -71,11 +71,6 @@ public class ArrayAnyAllExpression : Expression, IEquatable<ArrayAnyAllExpressio
         /// </summary>
         public virtual ArrayComparisonType ArrayComparisonType { get; }
 
-        /// <summary>
-        /// True if this instance represents: {operand} = ANY ({array})".
-        /// </summary>
-        public bool IsContainsExpression => ArrayComparisonType is ArrayComparisonType.ANY && Operator is "=";
-
         /// <summary>
         /// Constructs a <see cref="ArrayAnyAllExpression"/>.
         /// </summary>
@@ -90,14 +85,10 @@ public ArrayAnyAllExpression(
             [NotNull] Expression operand,
             [NotNull] Expression array)
         {
-            Check.NotNull(array, nameof(operatorSymbol));
-            Check.NotNull(operand, nameof(operand));
-            Check.NotNull(array, nameof(array));
-
             ArrayComparisonType = arrayComparisonType;
-            Operator = operatorSymbol;
-            Operand = operand;
-            Array = array;
+            Operator = Check.NotNull(operatorSymbol, nameof(operatorSymbol));
+            Operand = Check.NotNull(operand, nameof(operand));
+            Array = Check.NotNull(array, nameof(array));
         }
 
         /// <inheritdoc />
diff --git a/src/EFCore.PG/Query/Sql/Internal/NpgsqlQuerySqlGeneratorFactory.cs b/src/EFCore.PG/Query/Sql/Internal/NpgsqlQuerySqlGeneratorFactory.cs
index cd9c810e1..47c97eea9 100644
--- a/src/EFCore.PG/Query/Sql/Internal/NpgsqlQuerySqlGeneratorFactory.cs
+++ b/src/EFCore.PG/Query/Sql/Internal/NpgsqlQuerySqlGeneratorFactory.cs
@@ -1,4 +1,5 @@
 #region License
+
 // The PostgreSQL License
 //
 // Copyright (C) 2016 The Npgsql Development Team
@@ -19,6 +20,7 @@
 // AND FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS
 // ON AN "AS IS" BASIS, AND THE NPGSQL DEVELOPMENT TEAM HAS NO OBLIGATIONS
 // TO PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
+
 #endregion
 
 using JetBrains.Annotations;
@@ -29,18 +31,24 @@
 
 namespace Npgsql.EntityFrameworkCore.PostgreSQL.Query.Sql.Internal
 {
+    /// <summary>
+    /// The default factory for Npgsql-specific query SQL generators.
+    /// </summary>
     public class NpgsqlQuerySqlGeneratorFactory : QuerySqlGeneratorFactoryBase
     {
-        readonly INpgsqlOptions _npgsqlOptions;
+        /// <summary>
+        /// Represents options for Npgsql that can only be set by the service provider.
+        /// </summary>
+        [NotNull] readonly INpgsqlOptions _npgsqlOptions;
 
+        /// <inheritdoc />
         public NpgsqlQuerySqlGeneratorFactory(
             [NotNull] QuerySqlGeneratorDependencies dependencies,
             [NotNull] INpgsqlOptions npgsqlOptions)
             : base(dependencies)
-        {
-            _npgsqlOptions = npgsqlOptions;
-        }
+            => _npgsqlOptions = Check.NotNull(npgsqlOptions, nameof(npgsqlOptions));
 
+        /// <inheritdoc />
         public override IQuerySqlGenerator CreateDefault(SelectExpression selectExpression)
             => new NpgsqlQuerySqlGenerator(
                 Dependencies,