From 06ef276473f447859515bc72ea13e7e748697e64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcus=20Bl=C3=A4ttermann?= Date: Fri, 6 Feb 2026 10:46:15 +0100 Subject: [PATCH 1/3] test: avoid redundant html validation --- .github/workflows/ci.yml | 2 +- nuxt.config.ts | 5 ++++- package.json | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8320ecf6c..e1fa6a2af 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -150,7 +150,7 @@ jobs: run: pnpm install - name: 🏗️ Build project - run: pnpm build:playwright + run: NODE_ENV=test pnpm build - name: 🖥️ Test project (browser) run: pnpm test:browser:prebuilt diff --git a/nuxt.config.ts b/nuxt.config.ts index 54ba28333..108b6fba5 100644 --- a/nuxt.config.ts +++ b/nuxt.config.ts @@ -1,6 +1,9 @@ import process from 'node:process' import { currentLocales } from './config/i18n' +// log node env +console.log(`Running Nuxt in ${process.env.NODE_ENV} mode`) + export default defineNuxtConfig({ modules: [ // Workaround for Nuxt 4.3.0 regression: https://github.com/nuxt/nuxt/issues/34140 @@ -18,7 +21,7 @@ export default defineNuxtConfig({ }) }, '@unocss/nuxt', - '@nuxtjs/html-validator', + process.env.NODE_ENV === 'test' ? null : '@nuxtjs/html-validator', '@nuxt/scripts', '@nuxt/a11y', '@nuxt/fonts', diff --git a/package.json b/package.json index 30caadcf5..19ce809ec 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,6 @@ "scripts": { "build": "nuxt build", "build:lunaria": "node ./lunaria/lunaria.ts", - "build:playwright": "NODE_ENV=test pnpm build", "dev": "nuxt dev", "dev:docs": "pnpm run --filter npmx-docs dev --port=3001", "i18n:check": "node scripts/compare-translations.ts", From eeb001055470e1e2475dbd17835bbed07144efb3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcus=20Bl=C3=A4ttermann?= Date: Fri, 6 Feb 2026 11:02:14 +0100 Subject: [PATCH 2/3] fix: readd script --- .github/workflows/ci.yml | 4 ++-- package.json | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e1fa6a2af..d6dd737c9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -150,7 +150,7 @@ jobs: run: pnpm install - name: 🏗️ Build project - run: NODE_ENV=test pnpm build + run: pnpm build:playwright - name: 🖥️ Test project (browser) run: pnpm test:browser:prebuilt @@ -178,7 +178,7 @@ jobs: run: pnpm install - name: 🏗️ Build project - run: NODE_ENV=test pnpm build + run: pnpm build:playwright - name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode) run: ./scripts/lighthouse-a11y.sh diff --git a/package.json b/package.json index 19ce809ec..009926126 100644 --- a/package.json +++ b/package.json @@ -11,6 +11,7 @@ }, "scripts": { "build": "nuxt build", + "build:playwright": "NODE_ENV=test pnpm build", "build:lunaria": "node ./lunaria/lunaria.ts", "dev": "nuxt dev", "dev:docs": "pnpm run --filter npmx-docs dev --port=3001", From 197201c47ac5c333ddbed73dadf6c14abf99f98c Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Fri, 6 Feb 2026 11:34:53 +0000 Subject: [PATCH 3/3] refactor: enable only for browser tests --- .github/workflows/ci.yml | 6 ++++-- nuxt.config.ts | 7 +++---- package.json | 8 ++++---- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b88597b22..28e02f523 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -150,7 +150,9 @@ jobs: run: pnpm install - name: 🏗️ Build project - run: pnpm build:playwright + run: pnpm build:test + env: + VALIDATE_HTML: true - name: 🖥️ Test project (browser) run: pnpm test:browser:prebuilt @@ -178,7 +180,7 @@ jobs: run: pnpm install - name: 🏗️ Build project - run: pnpm build:playwright + run: pnpm build:test - name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode) run: ./scripts/lighthouse-a11y.sh diff --git a/nuxt.config.ts b/nuxt.config.ts index 6993e1f79..79be518fa 100644 --- a/nuxt.config.ts +++ b/nuxt.config.ts @@ -1,8 +1,6 @@ import process from 'node:process' import { currentLocales } from './config/i18n' - -// log node env -console.log(`Running Nuxt in ${process.env.NODE_ENV} mode`) +import { isCI, provider } from 'std-env' export default defineNuxtConfig({ modules: [ @@ -21,7 +19,7 @@ export default defineNuxtConfig({ }) }, '@unocss/nuxt', - process.env.NODE_ENV === 'test' ? null : '@nuxtjs/html-validator', + '@nuxtjs/html-validator', '@nuxt/scripts', '@nuxt/a11y', '@nuxt/fonts', @@ -198,6 +196,7 @@ export default defineNuxtConfig({ }, htmlValidator: { + enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML), failOnError: true, }, diff --git a/package.json b/package.json index ffeb0fcaa..407e16a66 100644 --- a/package.json +++ b/package.json @@ -11,8 +11,8 @@ }, "scripts": { "build": "nuxt build", - "build:playwright": "NODE_ENV=test pnpm build", "build:lunaria": "node ./lunaria/lunaria.ts", + "build:test": "NODE_ENV=test pnpm build", "dev": "nuxt dev", "dev:docs": "pnpm run --filter npmx-docs dev --port=3001", "i18n:check": "node scripts/compare-translations.ts", @@ -30,10 +30,10 @@ "generate:fixtures": "node scripts/generate-fixtures.ts", "generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear", "test": "vite test", - "test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt", + "test:browser": "pnpm build:test && pnpm test:browser:prebuilt", "test:browser:prebuilt": "playwright test", - "test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui", - "test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots", + "test:browser:ui": "pnpm build:test && pnpm test:browser:prebuilt --ui", + "test:browser:update": "pnpm build:test && pnpm test:browser:prebuilt --update-snapshots", "test:nuxt": "vite test --project nuxt", "test:types": "pnpm generate:lexicons && nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types", "test:unit": "vite test --project unit",