From e7abc8671a38c320f32ccf3ea5a0f7dd95f853c8 Mon Sep 17 00:00:00 2001 From: userquin Date: Mon, 9 Feb 2026 13:54:01 +0100 Subject: [PATCH 1/5] fix(ui): invalid html button markup --- app/components/Compare/PackageSelector.vue | 14 +++---- app/components/Header/AccountMenu.client.vue | 40 ++++++++++---------- app/components/Package/DeprecatedTree.vue | 4 +- app/components/Package/VulnerabilityTree.vue | 8 ++-- 4 files changed, 33 insertions(+), 33 deletions(-) diff --git a/app/components/Compare/PackageSelector.vue b/app/components/Compare/PackageSelector.vue index fd0efd385..7b4d0dd2a 100644 --- a/app/components/Compare/PackageSelector.vue +++ b/app/components/Compare/PackageSelector.vue @@ -178,13 +178,13 @@ function handleBlur() { :aria-label="$t('compare.no_dependency.add_column')" @click="addPackage(NO_DEPENDENCY_ID)" > -
+
-
+ + {{ $t('compare.no_dependency.typeahead_description') }} -
+
@@ -196,10 +196,10 @@ function handleBlur() { class="block w-full text-start" @click="addPackage(result.name)" > -
{{ result.name }}
-
+ {{ result.name }} + {{ result.description }} -
+
diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index 9d9bd3204..4ad58741f 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -65,7 +65,7 @@ function openAuthModal() { class="border-none" > -
-
+ @@ -163,10 +163,10 @@ function openAuthModal() { > -
-
~{{ npmUser }}
-
{{ $t('account_menu.npm_cli') }}
-
+ + ~{{ npmUser }} + {{ $t('account_menu.npm_cli') }} + -
-
@{{ atprotoUser.handle }}
-
{{ $t('account_menu.atmosphere') }}
-
+ + @{{ atprotoUser.handle }} + {{ $t('account_menu.atmosphere') }} + @@ -236,16 +236,16 @@ function openAuthModal() { /> -
-
+ + {{ isNpmConnecting ? $t('account_menu.connecting') : $t('account_menu.connect_npm_cli') }} -
-
{{ $t('account_menu.npm_cli_desc') }}
-
+
+ {{ $t('account_menu.npm_cli_desc') }} +
diff --git a/app/components/Package/DeprecatedTree.vue b/app/components/Package/DeprecatedTree.vue index f78d90b29..d8e06b795 100644 --- a/app/components/Package/DeprecatedTree.vue +++ b/app/components/Package/DeprecatedTree.vue @@ -53,12 +53,12 @@ function getDepthStyle(depth: DependencyDepth) { aria-controls="deprecated-tree-details" @click="isExpanded = !isExpanded" > -
+
+ -
+
-
+ +
+
From 425ef630b2e144f5e32b1b1888e48e708eb57a18 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Mon, 9 Feb 2026 13:10:15 +0000 Subject: [PATCH 2/5] fix: set spans to block in account menu --- app/components/Header/AccountMenu.client.vue | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index 4ad58741f..8bc23a0ca 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -164,7 +164,7 @@ function openAuthModal() { - ~{{ npmUser }} + ~{{ npmUser }} {{ $t('account_menu.npm_cli') }} - @{{ atprotoUser.handle }} + @{{ atprotoUser.handle }} {{ $t('account_menu.atmosphere') }} @@ -237,7 +239,7 @@ function openAuthModal() { - + {{ isNpmConnecting ? $t('account_menu.connecting') @@ -259,7 +261,7 @@ function openAuthModal() { - + {{ $t('account_menu.connect_atmosphere') }} {{ $t('account_menu.atmosphere_desc') }} From bae644626ae2d356c47f9da3f8819587191cd668 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Mon, 9 Feb 2026 13:23:05 +0000 Subject: [PATCH 3/5] fix: add block to first line --- app/components/Compare/PackageSelector.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/components/Compare/PackageSelector.vue b/app/components/Compare/PackageSelector.vue index 7b4d0dd2a..0ff26b077 100644 --- a/app/components/Compare/PackageSelector.vue +++ b/app/components/Compare/PackageSelector.vue @@ -178,7 +178,7 @@ function handleBlur() { :aria-label="$t('compare.no_dependency.add_column')" @click="addPackage(NO_DEPENDENCY_ID)" > - + @@ -196,7 +196,7 @@ function handleBlur() { class="block w-full text-start" @click="addPackage(result.name)" > - {{ result.name }} + {{ result.name }} {{ result.description }} From 9e601faee3161e8ef3e0981f4c32b872673f2e74 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Mon, 9 Feb 2026 13:24:22 +0000 Subject: [PATCH 4/5] chore: more block --- app/components/Package/DeprecatedTree.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/components/Package/DeprecatedTree.vue b/app/components/Package/DeprecatedTree.vue index d8e06b795..4d63a3eb6 100644 --- a/app/components/Package/DeprecatedTree.vue +++ b/app/components/Package/DeprecatedTree.vue @@ -53,7 +53,7 @@ function getDepthStyle(depth: DependencyDepth) { aria-controls="deprecated-tree-details" @click="isExpanded = !isExpanded" > - +