From 0adcfed0359b5402c2ff24392d1ae43a4a969bee Mon Sep 17 00:00:00 2001 From: Sebastian Nallar Date: Mon, 29 Sep 2025 13:49:56 -0300 Subject: [PATCH] [fixes][route53]: we create the record on both hosted zones --- k8s/scope/networking/dns/route53/manage_route | 26 ++++++++----------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/k8s/scope/networking/dns/route53/manage_route b/k8s/scope/networking/dns/route53/manage_route index 5a415b65..5b6d5238 100644 --- a/k8s/scope/networking/dns/route53/manage_route +++ b/k8s/scope/networking/dns/route53/manage_route @@ -33,20 +33,16 @@ fi echo "Found load balancer DNS: $ELB_DNS_NAME" -if [ "$SCOPE_VISIBILITY" = "public" ]; then - HOSTED_ZONES=("$HOSTED_PUBLIC_ZONE_ID") -else - HOSTED_ZONES=() - - if [[ -n "$HOSTED_PRIVATE_ZONE_ID" ]] && [[ "$HOSTED_PRIVATE_ZONE_ID" != "null" ]]; then - HOSTED_ZONES+=("$HOSTED_PRIVATE_ZONE_ID") - fi - - if [[ -n "$HOSTED_PUBLIC_ZONE_ID" ]] && [[ "$HOSTED_PUBLIC_ZONE_ID" != "null" ]]; then - if [[ "$HOSTED_PUBLIC_ZONE_ID" != "$HOSTED_PRIVATE_ZONE_ID" ]]; then - HOSTED_ZONES+=("$HOSTED_PUBLIC_ZONE_ID") - echo "Will create records in both public and private zones" - fi +HOSTED_ZONES=() + +if [[ -n "$HOSTED_PRIVATE_ZONE_ID" ]] && [[ "$HOSTED_PRIVATE_ZONE_ID" != "null" ]]; then + HOSTED_ZONES+=("$HOSTED_PRIVATE_ZONE_ID") +fi + +if [[ -n "$HOSTED_PUBLIC_ZONE_ID" ]] && [[ "$HOSTED_PUBLIC_ZONE_ID" != "null" ]]; then + if [[ "$HOSTED_PUBLIC_ZONE_ID" != "$HOSTED_PRIVATE_ZONE_ID" ]]; then + HOSTED_ZONES+=("$HOSTED_PUBLIC_ZONE_ID") + echo "Will create records in both public and private zones" fi fi @@ -88,4 +84,4 @@ for ZONE_ID in "${HOSTED_ZONES[@]}"; do } echo "Successfully $ACTION Route53 record" -done +done \ No newline at end of file