diff --git a/server/src/test/java/com/objectcomputing/checkins/services/fixture/FeedbackRequestFixture.java b/server/src/test/java/com/objectcomputing/checkins/services/fixture/FeedbackRequestFixture.java
index 201a67023e..bda6a1134b 100644
--- a/server/src/test/java/com/objectcomputing/checkins/services/fixture/FeedbackRequestFixture.java
+++ b/server/src/test/java/com/objectcomputing/checkins/services/fixture/FeedbackRequestFixture.java
@@ -4,6 +4,8 @@
import com.objectcomputing.checkins.services.memberprofile.MemberProfile;
import com.objectcomputing.checkins.services.reviews.ReviewPeriod;
import jnr.constants.platform.Local;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.time.LocalDate;
@@ -18,6 +20,8 @@
public interface FeedbackRequestFixture extends RepositoryFixture, FeedbackTemplateFixture {
+ static final Logger LOG = LoggerFactory.getLogger(FeedbackRequestFixture.class);
+
/**
* Creates a sample feedback request
* @param creator The {@link MemberProfile} of the creator of the feedback request
@@ -59,6 +63,8 @@ default FeedbackRequest saveSampleFeedbackRequest(MemberProfile creator, MemberP
}
default LocalDate getRandomLocalDateTime(LocalDateTime start, LocalDateTime end) {
+ if(start.isEqual(end)) return end.toLocalDate();
+
LocalDate startDate = start.toLocalDate();
long daysBetween = ChronoUnit.DAYS.between(startDate, end.toLocalDate());
Random random = new Random();
@@ -81,6 +87,8 @@ default FeedbackRequest saveSampleFeedbackRequest(MemberProfile creator, MemberP
default FeedbackRequest saveSampleFeedbackRequest(MemberProfile creator, MemberProfile requestee, MemberProfile recipient, UUID templateId, ReviewPeriod reviewPeriod, String status) {
LocalDate submitDate = getRandomLocalDateTime(reviewPeriod.getPeriodStartDate(), reviewPeriod.getCloseDate());
+ LOG.info("Period start date: {} Generated Submit Date: {}", reviewPeriod.getPeriodStartDate(), submitDate.atStartOfDay());
+ if(submitDate.atStartOfDay().isAfter(LocalDateTime.now())) submitDate = LocalDateTime.now().toLocalDate();
LocalDate sendDate = getRandomLocalDateTime(reviewPeriod.getPeriodStartDate(), submitDate.atStartOfDay());
return getFeedbackRequestRepository().save(new FeedbackRequest(creator.getId(), requestee.getId(), recipient.getId(), templateId, sendDate, null, status, submitDate, reviewPeriod.getId()));
}
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/fixture/ReviewPeriodFixture.java b/server/src/test/java/com/objectcomputing/checkins/services/fixture/ReviewPeriodFixture.java
index cd2cf0eded..af3e3863d0 100644
--- a/server/src/test/java/com/objectcomputing/checkins/services/fixture/ReviewPeriodFixture.java
+++ b/server/src/test/java/com/objectcomputing/checkins/services/fixture/ReviewPeriodFixture.java
@@ -3,6 +3,7 @@
import com.objectcomputing.checkins.services.reviews.ReviewPeriod;
import com.objectcomputing.checkins.services.reviews.ReviewStatus;
+import java.time.temporal.TemporalUnit;
import java.util.UUID;
import java.time.LocalDateTime;
import java.time.temporal.ChronoUnit;
@@ -10,12 +11,11 @@
public interface ReviewPeriodFixture extends RepositoryFixture {
default ReviewPeriod createADefaultReviewPeriod() {
- LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
- .truncatedTo(ChronoUnit.MILLIS);
- LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
- LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
- LocalDateTime startDate = launchDate.minusDays(30);
- LocalDateTime endDate = closeDate.minusDays(1);
+ LocalDateTime launchDate = LocalDateTime.now().plusDays(1).truncatedTo(ChronoUnit.DAYS);
+ LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+ LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+ LocalDateTime startDate = launchDate.minusDays(31);
+ LocalDateTime endDate = launchDate.minusDays(1);
return getReviewPeriodRepository().save(
new ReviewPeriod("Period of Time", ReviewStatus.OPEN, null, null,
launchDate, selfReviewCloseDate, closeDate,
@@ -27,12 +27,11 @@ default ReviewPeriod createADefaultReviewPeriod(ReviewStatus reviewStatus) {
}
default ReviewPeriod createADefaultReviewPeriod(ReviewStatus reviewStatus, UUID templateId) {
- LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
- .truncatedTo(ChronoUnit.MILLIS);
- LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
- LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
- LocalDateTime startDate = launchDate.minusDays(30);
- LocalDateTime endDate = closeDate.minusDays(1);
+ LocalDateTime launchDate = LocalDateTime.now().plusDays(1).truncatedTo(ChronoUnit.DAYS);
+ LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+ LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+ LocalDateTime startDate = launchDate.minusDays(31);
+ LocalDateTime endDate = launchDate.minusDays(1);
return getReviewPeriodRepository().save(
new ReviewPeriod("Period of Time", reviewStatus, templateId, null,
launchDate, selfReviewCloseDate, closeDate,
@@ -43,12 +42,12 @@ default ReviewPeriod createADefaultReviewPeriod(
LocalDateTime launchDate,
ReviewStatus reviewStatus,
UUID templateId, UUID selfReviewTemplateId) {
- launchDate = launchDate.truncatedTo(ChronoUnit.MILLIS);
+ launchDate = launchDate.truncatedTo(ChronoUnit.DAYS);
LocalDateTime selfReviewCloseDate = launchDate.plusDays(4);
- LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
- LocalDateTime startDate = launchDate.minusDays(30);
- LocalDateTime endDate = closeDate.minusDays(1);
+ LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+ LocalDateTime startDate = launchDate.minusDays(31);
+ LocalDateTime endDate = launchDate.minusDays(1);
return getReviewPeriodRepository().save(
new ReviewPeriod("Specific Launch Date", reviewStatus, templateId,
selfReviewTemplateId,
@@ -57,12 +56,11 @@ default ReviewPeriod createADefaultReviewPeriod(
}
default ReviewPeriod createASecondaryReviewPeriod() {
- LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
- .truncatedTo(ChronoUnit.MILLIS);
- LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
- LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
- LocalDateTime startDate = launchDate.minusDays(30);
- LocalDateTime endDate = closeDate.minusDays(1);
+ LocalDateTime launchDate = LocalDateTime.now().plusDays(1).truncatedTo(ChronoUnit.DAYS);
+ LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+ LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+ LocalDateTime startDate = launchDate.minusDays(31);
+ LocalDateTime endDate = launchDate.minusDays(1);
return getReviewPeriodRepository().save(
new ReviewPeriod("Period of Play", ReviewStatus.OPEN, null, null,
launchDate, selfReviewCloseDate, closeDate,
@@ -70,19 +68,15 @@ default ReviewPeriod createASecondaryReviewPeriod() {
}
default ReviewPeriod createAClosedReviewPeriod() {
- LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
- .truncatedTo(ChronoUnit.MILLIS);
- LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
- LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
- LocalDateTime startDate = launchDate.minusDays(30);
- LocalDateTime endDate = closeDate.minusDays(1);
+ LocalDateTime launchDate = LocalDateTime.now().plusDays(1).truncatedTo(ChronoUnit.DAYS);
+ LocalDateTime startDate = launchDate.minusDays(31);
+ LocalDateTime endDate = launchDate.minusDays(1);
return createAClosedReviewPeriod(startDate, endDate);
}
default ReviewPeriod createAClosedReviewPeriod(
LocalDateTime periodStart, LocalDateTime periodEnd) {
- LocalDateTime launchDate = periodEnd.plusMinutes(1)
- .truncatedTo(ChronoUnit.MILLIS).plusDays(1);
+ LocalDateTime launchDate = periodEnd.plusDays(1).truncatedTo(ChronoUnit.DAYS);
LocalDateTime selfReviewCloseDate = launchDate.plusDays(3);
LocalDateTime closeDate = selfReviewCloseDate.plusDays(7);
return getReviewPeriodRepository().save(
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodControllerTest.java b/server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodControllerTest.java
index 4ce4768577..261501737c 100644
--- a/server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodControllerTest.java
+++ b/server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodControllerTest.java
@@ -833,7 +833,7 @@ void testSelfReviewThreeDaysEmail() {
// launch date, the self-review closes 4 days after the launch date.
// So, to get the three day email, we just need to add 1 day to the
// launch date.
- LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1);
+ LocalDateTime launchDate = LocalDateTime.now().truncatedTo(ChronoUnit.DAYS);
checkSelfReviewEmail(launchDate, launchDate.plusDays(1),
" closes in three days!");
}
@@ -844,7 +844,7 @@ void testSelfReviewOneDayEmail() {
// launch date, the self-review closes 4 days after the launch date.
// So, to get the one day email, we just need to add 3 days to the
// launch date.
- LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1);
+ LocalDateTime launchDate = LocalDateTime.now().truncatedTo(ChronoUnit.DAYS);
checkSelfReviewEmail(launchDate, launchDate.plusDays(3),
" closes in one day!");
}
diff --git a/web-ui/src/components/action_item/ActionItemsPanel.test.jsx b/web-ui/src/components/action_item/ActionItemsPanel.test.jsx
index 5476f74548..5f00dcf947 100644
--- a/web-ui/src/components/action_item/ActionItemsPanel.test.jsx
+++ b/web-ui/src/components/action_item/ActionItemsPanel.test.jsx
@@ -71,7 +71,7 @@ const server = setupServer(
)
);
-beforeAll(() => server.listen());
+beforeAll(() => server.listen({ onUnhandledRequest(request, print) {} }));
afterEach(() => server.resetHandlers());
afterAll(() => server.close());
diff --git a/web-ui/src/components/agenda/Agenda.jsx b/web-ui/src/components/agenda/Agenda.jsx
index e005b9bf02..82bdd2e1ef 100644
--- a/web-ui/src/components/agenda/Agenda.jsx
+++ b/web-ui/src/components/agenda/Agenda.jsx
@@ -43,7 +43,7 @@ const AgendaItems = () => {
const currentUserId = memberProfile?.id;
const currentCheckin = selectCheckin(state, checkinId);
- const [agendaItems, setAgendaItems] = useState();
+ const [agendaItems, setAgendaItems] = useState([]);
const [description, setDescription] = useState('');
const [isLoading, setIsLoading] = useState(false);
diff --git a/web-ui/src/components/celebrations/MyAnniversary.test.jsx b/web-ui/src/components/celebrations/MyAnniversary.test.jsx
index ae44737e12..bfbea022fb 100644
--- a/web-ui/src/components/celebrations/MyAnniversary.test.jsx
+++ b/web-ui/src/components/celebrations/MyAnniversary.test.jsx
@@ -3,7 +3,7 @@ import MyAnniversary from './MyAnniversary';
import { AppContextProvider } from '../../context/AppContext';
import { BrowserRouter } from 'react-router-dom';
-const hideMyAnniversary = false;
+const hideMyAnniversary = () => {};
const myAnniversary = {
name: 'Suman Maroju',
anniversary: '12/29/2012',
diff --git a/web-ui/src/components/checkin/documents/CheckinDocs.jsx b/web-ui/src/components/checkin/documents/CheckinDocs.jsx
index 5ef08d7b86..353e0db5c6 100644
--- a/web-ui/src/components/checkin/documents/CheckinDocs.jsx
+++ b/web-ui/src/components/checkin/documents/CheckinDocs.jsx
@@ -56,7 +56,7 @@ const UploadDocs = () => {
});
}
} catch (e) {
- console.log(e);
+ console.error("getCheckinFiles: " + e);
}
}
if (csrf) {
@@ -98,7 +98,7 @@ const UploadDocs = () => {
setFiles([...files, data]);
} catch (e) {
setFileColors(fileColors => ({ ...fileColors, [file.name]: 'red' }));
- console.log({ e });
+ console.error("addFiles: " + e);
} finally {
setLoading(false);
}
diff --git a/web-ui/src/components/contribution_hours/ProgressBar.test.jsx b/web-ui/src/components/contribution_hours/ProgressBar.test.jsx
index 4efa37168e..a82438336a 100644
--- a/web-ui/src/components/contribution_hours/ProgressBar.test.jsx
+++ b/web-ui/src/components/contribution_hours/ProgressBar.test.jsx
@@ -3,9 +3,13 @@ import ProgressBar from './ProgressBar';
import renderer from 'react-test-renderer';
it('has billable hours', () => {
- snapshot(