From 0e088c6eba21c9779f1cc087141c9c0ca120fe10 Mon Sep 17 00:00:00 2001 From: Chad Elliott Date: Fri, 8 Nov 2024 09:21:38 -0600 Subject: [PATCH] Use review assignemnts to detect a lack of review period members, as well as missing reviewers. --- web-ui/src/components/reviews/TeamReviews.jsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web-ui/src/components/reviews/TeamReviews.jsx b/web-ui/src/components/reviews/TeamReviews.jsx index aa2489d488..5a6d92235f 100644 --- a/web-ui/src/components/reviews/TeamReviews.jsx +++ b/web-ui/src/components/reviews/TeamReviews.jsx @@ -647,9 +647,9 @@ const TeamReviews = ({ onBack, periodId }) => { if (!period.closeDate) return 'No close date was specified.'; if (!period.periodStartDate) return 'No period-start-date was specified.'; if (!period.periodEndDate) return 'No period-end-date was specified.'; - if (teamMembers.length === 0) return 'No members were added.'; - const haveReviewers = teamMembers.every( - member => getReviewers(member).length > 0 + if (assignments.length === 0) return 'No members were added.'; + const haveReviewers = assignments.every( + assignment => assignment.reviewerId != null ); if (!haveReviewers) return 'One or more members have no reviewer.'; return null; // no validation errors