From 3c182188ce21f4101ce4c7595d4f3fdc418dad6b Mon Sep 17 00:00:00 2001 From: Chad Elliott Date: Fri, 31 Jan 2025 15:01:41 -0600 Subject: [PATCH] Added logging to help debug development deployment. --- .../pulseresponse/PulseResponseController.java | 13 +++++++++++++ .../pulseresponse/SlackPulseResponseConverter.java | 9 +++++++++ 2 files changed, 22 insertions(+) diff --git a/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseController.java b/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseController.java index 4de57a315..d0b6f1389 100644 --- a/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseController.java +++ b/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseController.java @@ -25,6 +25,9 @@ import jakarta.validation.Valid; import jakarta.validation.constraints.NotNull; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.net.URI; import java.time.LocalDate; import java.util.Set; @@ -36,6 +39,7 @@ @ExecuteOn(TaskExecutors.BLOCKING) @Tag(name = "pulse-responses") public class PulseResponseController { + private static final Logger LOG = LoggerFactory.getLogger(PulseResponseController.class); private final PulseResponseService pulseResponseServices; private final MemberProfileServices memberProfileServices; @@ -146,13 +150,22 @@ public HttpResponse externalPulseResponse( @Header("X-Slack-Request-Timestamp") String timestamp, @Body String requestBody, HttpRequest request) { + // DEBUG Only + LOG.info(requestBody); + // Validate the request if (slackSignatureVerifier.verifyRequest(signature, timestamp, requestBody)) { + // DEBUG Only + LOG.info("Request has been verified"); + PulseResponseCreateDTO pulseResponseDTO = SlackPulseResponseConverter.get(memberProfileServices, requestBody); + // DEBUG Only + LOG.info("Request has been converted"); + // Create the pulse response PulseResponse pulseResponse = pulseResponseServices.unsecureSave( new PulseResponse( diff --git a/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java b/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java index 42dd43679..d2e71f95c 100644 --- a/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java +++ b/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java @@ -4,6 +4,9 @@ import com.objectcomputing.checkins.services.memberprofile.MemberProfile; import com.objectcomputing.checkins.services.memberprofile.MemberProfileServices; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.core.type.TypeReference; import com.fasterxml.jackson.core.JsonProcessingException; @@ -13,6 +16,8 @@ import java.time.LocalDate; public class SlackPulseResponseConverter { + private static final Logger LOG = LoggerFactory.getLogger(SlackPulseResponseConverter.class); + public static PulseResponseCreateDTO get( MemberProfileServices memberProfileServices, String body) { final String key = "payload="; @@ -50,11 +55,14 @@ public static PulseResponseCreateDTO get( return response; } catch(JsonProcessingException ex) { + LOG.error(ex.getMessage()); throw new BadArgException(ex.getMessage()); } catch(NumberFormatException ex) { + LOG.error(ex.getMessage()); throw new BadArgException("Pulse scores must be integers"); } } else { + LOG.error(body); throw new BadArgException("Invalid pulse response body"); } } @@ -70,6 +78,7 @@ private static String getMappedValue(Map map, } if (required) { + LOG.error("Expected {}.{} was not found", key, valueKey); throw new BadArgException( String.format("Expected %s.%s was not found", key, valueKey)); } else {