From 56c1cd4b78a87a4634769883e7db272cf4c48263 Mon Sep 17 00:00:00 2001 From: Chad Elliott Date: Mon, 17 Feb 2025 11:20:43 -0600 Subject: [PATCH 1/2] If a supervisor is terminated, this would blow up on the check for supervisor id. --- web-ui/src/components/reviews/TeamReviews.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web-ui/src/components/reviews/TeamReviews.jsx b/web-ui/src/components/reviews/TeamReviews.jsx index ef70a54d5..87a30b468 100644 --- a/web-ui/src/components/reviews/TeamReviews.jsx +++ b/web-ui/src/components/reviews/TeamReviews.jsx @@ -172,7 +172,7 @@ const TeamReviews = ({ onBack, periodId }) => { useEffect(() => { const myId = currentUser?.id; const supervisors = selectSupervisors(state); - const isManager = supervisors.some(s => s.id === myId); + const isManager = supervisors.some(s => s?.id === myId); const period = selectReviewPeriod(state, periodId); if (period) { setApprovalState(period.reviewStatus === ReviewStatus.AWAITING_APPROVAL); From 1b5145dc30655af7fd6b1d50d6603d3342f1e0b3 Mon Sep 17 00:00:00 2001 From: Chad Elliott Date: Mon, 17 Feb 2025 11:21:19 -0600 Subject: [PATCH 2/2] Allow a user to view their self-review for closed review periods. --- web-ui/src/components/reviews/periods/ReviewPeriods.jsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/web-ui/src/components/reviews/periods/ReviewPeriods.jsx b/web-ui/src/components/reviews/periods/ReviewPeriods.jsx index b62d2e980..cedd2d151 100644 --- a/web-ui/src/components/reviews/periods/ReviewPeriods.jsx +++ b/web-ui/src/components/reviews/periods/ReviewPeriods.jsx @@ -327,8 +327,13 @@ const ReviewPeriods = ({ onPeriodSelected, mode }) => { case ReviewStatus.OPEN: onPeriodSelected(id); break; + case ReviewStatus.CLOSED: + if (mode === selfReviewMode) { + onPeriodSelected(id); + } + break; default: - // We do nothing if the status is CLOSED or UNKNOWN. + // We do nothing if the status is UNKNOWN. break; } },