From 42b073ae8b5df69d0abbbd5281b5804ffc859132 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Tue, 9 Dec 2025 21:25:22 +0000 Subject: [PATCH 1/2] dev Signed-off-by: Rudi Grinberg From d303c8018c4729b6246838064015a04054bf86c7 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Sun, 21 Dec 2025 11:56:57 +0000 Subject: [PATCH 2/2] refactor(trace): add [Config] category Signed-off-by: Rudi Grinberg --- src/dune_trace/category.ml | 4 ++++ src/dune_trace/category.mli | 1 + src/dune_trace/dune_trace.mli | 1 + src/dune_trace/event.ml | 8 ++++++-- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/dune_trace/category.ml b/src/dune_trace/category.ml index f9716905873..4b5dfdf1ef3 100644 --- a/src/dune_trace/category.ml +++ b/src/dune_trace/category.ml @@ -13,6 +13,7 @@ type t = | Promote | Build | Debug + | Config let all = [ Rpc @@ -27,6 +28,7 @@ let all = ; Promote ; Build ; Debug + ; Config ] ;; @@ -43,6 +45,7 @@ let to_string = function | Promote -> "promote" | Build -> "build" | Debug -> "debug" + | Config -> "config" ;; let of_string = @@ -71,5 +74,6 @@ module Set = Bit_set.Make (struct | Promote -> 9 | Build -> 10 | Debug -> 11 + | Config -> 12 ;; end) diff --git a/src/dune_trace/category.mli b/src/dune_trace/category.mli index ac9b4b5c64c..8e82b3fb744 100644 --- a/src/dune_trace/category.mli +++ b/src/dune_trace/category.mli @@ -11,6 +11,7 @@ type t = | Promote | Build | Debug + | Config val to_string : t -> string val of_string : string -> t option diff --git a/src/dune_trace/dune_trace.mli b/src/dune_trace/dune_trace.mli index 26cdabbf41c..a65a11d904d 100644 --- a/src/dune_trace/dune_trace.mli +++ b/src/dune_trace/dune_trace.mli @@ -14,6 +14,7 @@ module Category : sig | Promote | Build | Debug + | Config val of_string : string -> t option end diff --git a/src/dune_trace/event.ml b/src/dune_trace/event.ml index e2e1d539dbd..667c70450e3 100644 --- a/src/dune_trace/event.ml +++ b/src/dune_trace/event.ml @@ -75,14 +75,18 @@ let config ~version = in let open Chrome_trace in let ts = make_ts (Time.now ()) in - let common = Event.common_fields ~cat:[ "config" ] ~name:"config" ~ts () in + let common = + Event.common_fields ~cat:[ Category.to_string Config ] ~name:"config" ~ts () + in Event.instant ~args common ;; let exit () = let open Chrome_trace in let ts = make_ts (Time.now ()) in - let common = Event.common_fields ~cat:[ "config" ] ~name:"exit" ~ts () in + let common = + Event.common_fields ~cat:[ Category.to_string Config ] ~name:"exit" ~ts () + in Event.instant common ;;