From fba366486a84cc35f807e4bf8d7a781388ce3241 Mon Sep 17 00:00:00 2001 From: Thomas Poignant Date: Fri, 7 Jun 2024 18:31:30 +0200 Subject: [PATCH 1/2] feat!: Reverse the logic for supportedTypes Signed-off-by: Thomas Poignant --- service/openapi.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/service/openapi.yaml b/service/openapi.yaml index 0c34714..21f2df9 100644 --- a/service/openapi.yaml +++ b/service/openapi.yaml @@ -339,14 +339,17 @@ components: type: object description: Configurations specific for flag evaluations in OFREP provider implementation properties: - unsupportedTypes: - description: A list of unsupported types by the flag management system. Evaluating a flag of a listed type through OFREP provider will result in an error and yield the default value. + supportedTypes: + description: | + A list of supported types by the flag management system. + Evaluating a flag of a listed type through OFREP provider will result in an error and yield the default value. Undefined means that the flag management system is supporting all types. type: array items: type: string enum: [int, float, string, boolean, object] examples: - ["object", "int", "float"] + - null featureCacheInvalidation: type: object description: Configuration for the cache cacheInvalidation From 94e869dbac518ddc26074254a35715150cd65376 Mon Sep 17 00:00:00 2001 From: Thomas Poignant Date: Mon, 10 Jun 2024 09:21:59 +0200 Subject: [PATCH 2/2] fix Signed-off-by: Thomas Poignant --- service/openapi.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/service/openapi.yaml b/service/openapi.yaml index 21f2df9..3efe489 100644 --- a/service/openapi.yaml +++ b/service/openapi.yaml @@ -341,8 +341,8 @@ components: properties: supportedTypes: description: | - A list of supported types by the flag management system. - Evaluating a flag of a listed type through OFREP provider will result in an error and yield the default value. Undefined means that the flag management system is supporting all types. + Evaluating a flag of unlisted type through the OFREP provider will result in an error and yield the default value. + However, when supportedTypes is undefined/empty, provider assumes that all flag evaluation types are supported by the flag management system type: array items: type: string