From 8ba7ecccb8e8827d277ec9b42c986bc586270108 Mon Sep 17 00:00:00 2001 From: Oblivion Date: Sun, 19 Dec 2021 12:07:01 +0000 Subject: [PATCH] ZipkinExporter shutdown --- .../opentelemetry/exporters/zipkin/zipkin_exporter.h | 5 +---- exporters/zipkin/src/zipkin_exporter.cc | 6 ++++++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/exporters/zipkin/include/opentelemetry/exporters/zipkin/zipkin_exporter.h b/exporters/zipkin/include/opentelemetry/exporters/zipkin/zipkin_exporter.h index 0bb3eb8c76..aba926165f 100644 --- a/exporters/zipkin/include/opentelemetry/exporters/zipkin/zipkin_exporter.h +++ b/exporters/zipkin/include/opentelemetry/exporters/zipkin/zipkin_exporter.h @@ -82,10 +82,7 @@ class ZipkinExporter final : public opentelemetry::sdk::trace::SpanExporter * @param timeout an optional timeout, default to max. */ bool Shutdown( - std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override - { - return true; - } + std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override; private: void InitializeLocalEndpoint(); diff --git a/exporters/zipkin/src/zipkin_exporter.cc b/exporters/zipkin/src/zipkin_exporter.cc index 457bfa4b35..cbd49a344b 100644 --- a/exporters/zipkin/src/zipkin_exporter.cc +++ b/exporters/zipkin/src/zipkin_exporter.cc @@ -98,6 +98,12 @@ void ZipkinExporter::InitializeLocalEndpoint() local_end_point_["port"] = url_parser_.port_; } +bool ZipkinExporter::Shutdown(std::chrono::microseconds timeout) noexcept +{ + isShutdown_ = true; + return true; +} + } // namespace zipkin } // namespace exporter OPENTELEMETRY_END_NAMESPACE