From 2e8130e48aebf4d06b05cf670d3c9d6bf6f67514 Mon Sep 17 00:00:00 2001 From: Oblivion Date: Sun, 13 Mar 2022 11:10:42 +0000 Subject: [PATCH 1/2] AttributesProcessor missing dtor --- .../opentelemetry/sdk/metrics/view/attributes_processor.h | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h b/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h index fdc4e35c53..ebd22b79b4 100644 --- a/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h +++ b/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h @@ -23,6 +23,7 @@ class AttributesProcessor // @returns The processed attributes virtual MetricAttributes process( const opentelemetry::common::KeyValueIterable &attributes) const noexcept = 0; + virtual ~AttributesProcessor() = default; }; /** From 258ca98d442572cee48e35267123ceb1572a0bec Mon Sep 17 00:00:00 2001 From: Oblivion Date: Sun, 13 Mar 2022 11:12:31 +0000 Subject: [PATCH 2/2] format --- .../opentelemetry/sdk/metrics/view/attributes_processor.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h b/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h index ebd22b79b4..d82607357f 100644 --- a/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h +++ b/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h @@ -23,7 +23,8 @@ class AttributesProcessor // @returns The processed attributes virtual MetricAttributes process( const opentelemetry::common::KeyValueIterable &attributes) const noexcept = 0; - virtual ~AttributesProcessor() = default; + + virtual ~AttributesProcessor() = default; }; /**