From c03f2568a1a6153aeca6b7e7d77bc95a6b0473a6 Mon Sep 17 00:00:00 2001 From: Johannes Tax Date: Thu, 23 Jul 2020 08:03:37 -0700 Subject: [PATCH 1/3] Use gcc-4.8 for legacy tests --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a5d36c4a61..eccb696e87 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -55,6 +55,9 @@ jobs: sudo ./ci/install_gcc48.sh - name: run tests run: ./ci/do_ci.sh bazel.legacy.test + env: + CC: /usr/bin/gcc-4.8 + CXX: /usr/bin/g++-4.8 bazel_test: name: Bazel From 9ee9acc100910a846c68df0bb21c23dfe83c82b0 Mon Sep 17 00:00:00 2001 From: Johannes Tax Date: Thu, 23 Jul 2020 08:22:18 -0700 Subject: [PATCH 2/3] Fix --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eccb696e87..262319a7b1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,6 @@ jobs: run: ./ci/do_ci.sh bazel.legacy.test env: CC: /usr/bin/gcc-4.8 - CXX: /usr/bin/g++-4.8 bazel_test: name: Bazel From 8daca18fcd92d457c77b20fc11b1fdb4fdd332ed Mon Sep 17 00:00:00 2001 From: Johannes Tax Date: Thu, 23 Jul 2020 08:32:25 -0700 Subject: [PATCH 3/3] Fx --- exporters/ostream/src/span_exporter.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exporters/ostream/src/span_exporter.cc b/exporters/ostream/src/span_exporter.cc index fe7cb076d8..7e2e4237ab 100644 --- a/exporters/ostream/src/span_exporter.cc +++ b/exporters/ostream/src/span_exporter.cc @@ -11,7 +11,7 @@ namespace exporter namespace trace { OStreamSpanExporter::OStreamSpanExporter(std::ostream &sout) noexcept - : sout_{sout} {} + : sout_(sout) {} std::unique_ptr OStreamSpanExporter::MakeRecordable() noexcept {