diff --git a/ext/include/opentelemetry/ext/zpages/tracez_processor.h b/ext/include/opentelemetry/ext/zpages/tracez_processor.h index 926e430ead..c96461db74 100644 --- a/ext/include/opentelemetry/ext/zpages/tracez_processor.h +++ b/ext/include/opentelemetry/ext/zpages/tracez_processor.h @@ -7,9 +7,9 @@ #include #include +#include "opentelemetry/ext/zpages/threadsafe_span_data.h" #include "opentelemetry/sdk/trace/processor.h" #include "opentelemetry/sdk/trace/recordable.h" -#include "opentelemetry/sdk/trace/span_data.h" OPENTELEMETRY_BEGIN_NAMESPACE namespace ext @@ -25,8 +25,8 @@ class TracezSpanProcessor : public opentelemetry::sdk::trace::SpanProcessor public: struct CollectedSpans { - std::unordered_set running; - std::vector> completed; + std::unordered_set running; + std::vector> completed; }; /* @@ -40,8 +40,7 @@ class TracezSpanProcessor : public opentelemetry::sdk::trace::SpanProcessor */ std::unique_ptr MakeRecordable() noexcept override { - return std::unique_ptr( - new opentelemetry::sdk::trace::SpanData); + return std::unique_ptr(new ThreadsafeSpanData); } /* diff --git a/ext/src/zpages/tracez_processor.cc b/ext/src/zpages/tracez_processor.cc index 8e1dc5600d..779f6fd061 100644 --- a/ext/src/zpages/tracez_processor.cc +++ b/ext/src/zpages/tracez_processor.cc @@ -9,7 +9,7 @@ namespace zpages void TracezSpanProcessor::OnStart(opentelemetry::sdk::trace::Recordable &span) noexcept { std::lock_guard lock(mtx_); - spans_.running.insert(static_cast(&span)); + spans_.running.insert(static_cast(&span)); } void TracezSpanProcessor::OnEnd( @@ -17,14 +17,14 @@ void TracezSpanProcessor::OnEnd( { if (span == nullptr) return; - auto span_raw = static_cast(span.get()); + auto span_raw = static_cast(span.get()); std::lock_guard lock(mtx_); auto span_it = spans_.running.find(span_raw); if (span_it != spans_.running.end()) { spans_.running.erase(span_it); - spans_.completed.push_back(std::unique_ptr( - static_cast(span.release()))); + spans_.completed.push_back( + std::unique_ptr(static_cast(span.release()))); } } diff --git a/ext/test/zpages/tracez_processor_test.cc b/ext/test/zpages/tracez_processor_test.cc index 42a8736302..9d9fb3afe6 100644 --- a/ext/test/zpages/tracez_processor_test.cc +++ b/ext/test/zpages/tracez_processor_test.cc @@ -4,8 +4,8 @@ #include +#include "opentelemetry/ext/zpages/threadsafe_span_data.h" #include "opentelemetry/nostd/span.h" -#include "opentelemetry/sdk/trace/span_data.h" #include "opentelemetry/sdk/trace/tracer.h" using namespace opentelemetry::sdk::trace; @@ -18,8 +18,8 @@ using namespace opentelemetry::ext::zpages; * and running_spans. completed_spans contains all spans (cumulative), unless marked otherwise */ void UpdateSpans(std::shared_ptr &processor, - std::vector> &completed, - std::unordered_set &running, + std::vector> &completed, + std::unordered_set &running, bool store_only_new_completed = false) { auto spans = processor->GetSpanSnapshot(); @@ -47,7 +47,7 @@ void UpdateSpans(std::shared_ptr &processor, * no more or less */ bool ContainsNames(const std::vector &names, - std::unordered_set &running, + std::unordered_set &running, unsigned int name_start = 0, unsigned int name_end = 0, bool one_to_one_correspondence = false) @@ -95,7 +95,7 @@ bool ContainsNames(const std::vector &names, * no more or less */ bool ContainsNames(const std::vector &names, - std::vector> &completed, + std::vector> &completed, unsigned int name_start = 0, unsigned int name_end = 0, bool one_to_one_correspondence = false) @@ -186,8 +186,8 @@ class TracezProcessor : public ::testing::Test std::shared_ptr processor; std::shared_ptr tracer; - std::unordered_set running; - std::vector> completed; + std::unordered_set running; + std::vector> completed; std::vector span_names; std::vector> span_vars;