From 91ca7b9d6b3c76910fb913b370e6e5b35fb9efc0 Mon Sep 17 00:00:00 2001 From: refactor-droidyy Date: Sun, 1 Mar 2020 21:46:11 +0530 Subject: [PATCH 1/2] hide-password icon --- .../com/mifos/mobile/passcode/MifosPassCodeActivity.java | 7 ++----- .../src/main/res/drawable/ic_visibility_48px.xml | 2 +- .../src/main/res/drawable/ic_visibility_off_24dp.xml | 9 +++++++++ 3 files changed, 12 insertions(+), 6 deletions(-) create mode 100644 mifos-passcode/src/main/res/drawable/ic_visibility_off_24dp.xml diff --git a/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java b/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java index 4088d21..2815661 100644 --- a/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java +++ b/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java @@ -19,7 +19,6 @@ import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AppCompatActivity; import androidx.appcompat.widget.AppCompatButton; -import androidx.core.content.ContextCompat; import androidx.core.widget.NestedScrollView; public abstract class MifosPassCodeActivity extends AppCompatActivity implements MifosPassCodeView. @@ -308,11 +307,9 @@ public void clickedBackSpace(View v) { public void visibilityChange(View view) { mifosPassCodeView.revertPassCodeVisibility(); if (!mifosPassCodeView.passcodeVisible()) { - ivVisibility.setColorFilter(ContextCompat.getColor(MifosPassCodeActivity.this, - R.color.light_grey)); + ivVisibility.setImageResource(R.drawable.ic_visibility_48px); } else { - ivVisibility.setColorFilter(ContextCompat.getColor(MifosPassCodeActivity.this, - R.color.gray_dark)); + ivVisibility.setImageResource(R.drawable.ic_visibility_off_24dp); } } diff --git a/mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml b/mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml index 44f9d4f..8a550a2 100644 --- a/mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml +++ b/mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml @@ -4,6 +4,6 @@ android:viewportWidth="48.0" android:viewportHeight="48.0"> diff --git a/mifos-passcode/src/main/res/drawable/ic_visibility_off_24dp.xml b/mifos-passcode/src/main/res/drawable/ic_visibility_off_24dp.xml new file mode 100644 index 0000000..d4cfc72 --- /dev/null +++ b/mifos-passcode/src/main/res/drawable/ic_visibility_off_24dp.xml @@ -0,0 +1,9 @@ + + + From d2284c9250040a191793050ec5ddb6f7de624248 Mon Sep 17 00:00:00 2001 From: refactor-droidyy Date: Sun, 15 Mar 2020 18:46:31 +0530 Subject: [PATCH 2/2] Rename ic_visibility_48px to ic_visibility_on_48px --- .../java/com/mifos/mobile/passcode/MifosPassCodeActivity.java | 2 +- .../{ic_visibility_48px.xml => ic_visibility_on_48px.xml} | 0 mifos-passcode/src/main/res/layout/activity_pass_code.xml | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename mifos-passcode/src/main/res/drawable/{ic_visibility_48px.xml => ic_visibility_on_48px.xml} (100%) diff --git a/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java b/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java index 2815661..81bc684 100644 --- a/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java +++ b/mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java @@ -307,7 +307,7 @@ public void clickedBackSpace(View v) { public void visibilityChange(View view) { mifosPassCodeView.revertPassCodeVisibility(); if (!mifosPassCodeView.passcodeVisible()) { - ivVisibility.setImageResource(R.drawable.ic_visibility_48px); + ivVisibility.setImageResource(R.drawable.ic_visibility_on_48px); } else { ivVisibility.setImageResource(R.drawable.ic_visibility_off_24dp); } diff --git a/mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml b/mifos-passcode/src/main/res/drawable/ic_visibility_on_48px.xml similarity index 100% rename from mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml rename to mifos-passcode/src/main/res/drawable/ic_visibility_on_48px.xml diff --git a/mifos-passcode/src/main/res/layout/activity_pass_code.xml b/mifos-passcode/src/main/res/layout/activity_pass_code.xml index 6b15861..389d0f0 100644 --- a/mifos-passcode/src/main/res/layout/activity_pass_code.xml +++ b/mifos-passcode/src/main/res/layout/activity_pass_code.xml @@ -64,7 +64,7 @@ android:layout_marginStart="@dimen/default_padding" android:layout_marginLeft="@dimen/default_padding" android:onClick="visibilityChange" - app:srcCompat="@drawable/ic_visibility_48px" /> + app:srcCompat="@drawable/ic_visibility_on_48px" />