From 6711e27bb95977a6d752e120719d94fdbe325ab9 Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Wed, 5 Nov 2025 06:55:32 +0100 Subject: [PATCH 1/4] fix: space batch actions not loading in spaces table --- packages/web-pkg/src/components/FilesList/ResourceTable.vue | 2 +- packages/web-pkg/src/components/FilesList/ResourceTiles.vue | 6 ++---- .../tests/unit/components/FilesList/ResourceTiles.spec.ts | 3 +++ 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/web-pkg/src/components/FilesList/ResourceTable.vue b/packages/web-pkg/src/components/FilesList/ResourceTable.vue index 527cfd2e2f..5d38be1f84 100644 --- a/packages/web-pkg/src/components/FilesList/ResourceTable.vue +++ b/packages/web-pkg/src/components/FilesList/ResourceTable.vue @@ -672,7 +672,7 @@ export default defineComponent({ const toggleSelection = (resourceId: string) => { resourcesStore.toggleSelection(resourceId) - emitSelect(resourcesStore.selectedIds) + emitSelect([...resourcesStore.selectedIds]) } const getResourceLink = (resource: Resource) => { diff --git a/packages/web-pkg/src/components/FilesList/ResourceTiles.vue b/packages/web-pkg/src/components/FilesList/ResourceTiles.vue index 9501e76f75..e7338f45f6 100644 --- a/packages/web-pkg/src/components/FilesList/ResourceTiles.vue +++ b/packages/web-pkg/src/components/FilesList/ResourceTiles.vue @@ -496,10 +496,8 @@ const toggleTile = (data: [Resource, MouseEvent | KeyboardEvent], event?: MouseE } const toggleSelection = (resource: Resource) => { - const selected = !isResourceSelected(resource) - ? [...selectedIds, resource.id] - : selectedIds.filter((id) => id !== resource.id) - emit('update:selectedIds', selected) + resourcesStore.toggleSelection(resource.id) + emit('update:selectedIds', [...resourcesStore.selectedIds]) } const getResourceCheckboxLabel = (resource: Resource) => { diff --git a/packages/web-pkg/tests/unit/components/FilesList/ResourceTiles.spec.ts b/packages/web-pkg/tests/unit/components/FilesList/ResourceTiles.spec.ts index d09e083f62..9fb0639d42 100644 --- a/packages/web-pkg/tests/unit/components/FilesList/ResourceTiles.spec.ts +++ b/packages/web-pkg/tests/unit/components/FilesList/ResourceTiles.spec.ts @@ -8,6 +8,7 @@ import { useCanBeOpenedWithSecureView } from '../../../../src/composables/resour import { displayPositionedDropdown } from '../../../../src/helpers/contextMenuDropdown' import { OcFilterChip } from '@opencloud-eu/design-system/components' import { ResourceIndicator } from '../../../../src/helpers/statusIndicators' +import { useResourcesStore } from '../../../../src' vi.mock('../../../../src/helpers/contextMenuDropdown') vi.mock('../../../../src/composables/viewMode', async (importOriginal) => ({ @@ -120,6 +121,8 @@ describe('ResourceTiles component', () => { preventDefault: vi.fn() } as unknown as MouseEvent + const resourcesStore = useResourcesStore() + resourcesStore.selectedIds = [resources[0].id] await resourceTile.vm.$emit('click', mockMouseEvent) expect(wrapper.emitted('update:selectedIds')).toBeTruthy() expect(wrapper.emitted('update:selectedIds')[0][0]).toEqual([resources[0].id]) From 11037e4ad965667eff423a5948f5b6c436080acd Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Wed, 5 Nov 2025 07:23:58 +0100 Subject: [PATCH 2/4] refactor: ResourceTable to script setup --- .../components/FilesList/ResourceTable.vue | 1604 +++++++---------- .../filesList/useResourceRouteResolver.ts | 2 +- 2 files changed, 675 insertions(+), 931 deletions(-) diff --git a/packages/web-pkg/src/components/FilesList/ResourceTable.vue b/packages/web-pkg/src/components/FilesList/ResourceTable.vue index 5d38be1f84..776bca85c8 100644 --- a/packages/web-pkg/src/components/FilesList/ResourceTable.vue +++ b/packages/web-pkg/src/components/FilesList/ResourceTable.vue @@ -242,7 +242,6 @@ @@ -268,17 +266,8 @@ -