diff --git a/packages/design-system/src/components/OcDrop/OcDrop.spec.ts b/packages/design-system/src/components/OcDrop/OcDrop.spec.ts index 4f053ce843..8e9dd9febd 100644 --- a/packages/design-system/src/components/OcDrop/OcDrop.spec.ts +++ b/packages/design-system/src/components/OcDrop/OcDrop.spec.ts @@ -1,6 +1,5 @@ import { defaultPlugins, mount, shallowMount } from '@opencloud-eu/web-test-helpers' import Drop from './OcDrop.vue' -import { getTailwindPaddingClass, SizeType } from '../../helpers' import { computed, nextTick } from 'vue' import { useIsMobile } from '../../composables' @@ -53,25 +52,6 @@ describe('OcDrop', () => { } }) - it.each([ - 'xsmall', - 'small', - 'medium', - 'large', - 'xlarge', - 'xxlarge', - 'remove' - ])('handles padding size prop for value %s', async (size) => { - const { wrapper } = dom({ paddingSize: size }) - - const drop = wrapper.findComponent({ name: 'oc-drop' }) - await nextTick() - - const tailwindClassObj = getTailwindPaddingClass(size) - const tailwindClass = Object.entries(tailwindClassObj).find(([, v]) => v)?.[0] - expect(drop.html().includes(tailwindClass)).toBeTruthy() - }) - describe('tippy', () => { it('inits tippy', async () => { const { wrapper } = dom() diff --git a/packages/design-system/src/components/OcDrop/OcDrop.vue b/packages/design-system/src/components/OcDrop/OcDrop.vue index a82fdec415..0a9f3cc1bd 100644 --- a/packages/design-system/src/components/OcDrop/OcDrop.vue +++ b/packages/design-system/src/components/OcDrop/OcDrop.vue @@ -13,10 +13,10 @@
- + - +
@@ -140,6 +140,7 @@ const emit = defineEmits() defineSlots() const { isMobile } = useIsMobile() +const isOpen = ref(false) const useBottomDrawer = computed(() => unref(isMobile) && !enforceDropOnMobile) const bottomDrawerRef = useTemplateRef('bottomDrawerRef') @@ -182,10 +183,6 @@ const onFocusOut = (event: FocusEvent) => { } } -onBeforeUnmount(() => { - drop.value?.removeEventListener('focusout', onFocusOut) -}) - const triggerMapping = computed(() => { return ( { @@ -211,6 +208,7 @@ watch( ) onBeforeUnmount(() => { + unref(drop)?.removeEventListener('focusout', onFocusOut) destroy(unref(tippyInstance)) }) @@ -236,15 +234,17 @@ const initializeTippy = () => { theme: 'none', maxWidth: 416, offset, - ...(!isNestedElement && { - onShow: (instance) => { - emit('showDrop') + onShow: (instance) => { + isOpen.value = true + emit('showDrop') + if (!isNestedElement) { hideAll({ exclude: instance }) - }, - onHide: () => { - emit('hideDrop') } - }), + }, + onHide: () => { + isOpen.value = false + emit('hideDrop') + }, popperOptions: { ...popperOptions, modifiers: [ diff --git a/packages/design-system/src/components/OcDrop/__snapshots__/OcDrop.spec.ts.snap b/packages/design-system/src/components/OcDrop/__snapshots__/OcDrop.spec.ts.snap index a67d5a7782..6e077773eb 100644 --- a/packages/design-system/src/components/OcDrop/__snapshots__/OcDrop.spec.ts.snap +++ b/packages/design-system/src/components/OcDrop/__snapshots__/OcDrop.spec.ts.snap @@ -10,7 +10,7 @@ exports[`OcDrop > tippy > renders tippy 1`] = `

tippy > renders tippy 1`] = ` >
tippy > renders tippy 2`] = `

@@ -126,7 +110,7 @@ exports[`OcDrop > tippy > renders tippy 3`] = `

tippy > renders tippy 3`] = ` >
([ + { size: 'xsmall', class: 'p-1' }, + { size: 'small', class: 'p-2' }, + { size: 'medium', class: 'p-4' }, + { size: 'large', class: 'p-6' }, + { size: 'xlarge', class: 'p-12' }, + { size: 'xxlarge', class: 'p-24' }, + { size: 'remove', class: 'p-0' } +])('gets the correct tailwind padding class for a given size', ({ size, class: tailwindClass }) => { + const tailwindClassObj = getTailwindPaddingClass(size) as Record + expect(tailwindClassObj[tailwindClass]).toBeTruthy() +}) diff --git a/packages/web-app-admin-settings/tests/unit/components/Spaces/__snapshots__/SpacesList.spec.ts.snap b/packages/web-app-admin-settings/tests/unit/components/Spaces/__snapshots__/SpacesList.spec.ts.snap index 1d4ff7df4b..212689170a 100644 --- a/packages/web-app-admin-settings/tests/unit/components/Spaces/__snapshots__/SpacesList.spec.ts.snap +++ b/packages/web-app-admin-settings/tests/unit/components/Spaces/__snapshots__/SpacesList.spec.ts.snap @@ -171,11 +171,7 @@ exports[`SpacesList > should render all spaces in a table 1`] = ` return svg; }" aria-hidden="true" focusable="false" class="size-5.5">
-
- -
- -
+
@@ -233,11 +229,7 @@ exports[`SpacesList > should render all spaces in a table 1`] = ` return svg; }" aria-hidden="true" focusable="false" class="size-5.5">
-
- -
- -
+
diff --git a/packages/web-app-files/src/components/Search/List.vue b/packages/web-app-files/src/components/Search/List.vue index 2b53ef2bc5..fda0d129e1 100644 --- a/packages/web-app-files/src/components/Search/List.vue +++ b/packages/web-app-files/src/components/Search/List.vue @@ -114,9 +114,9 @@ /> -