From 76c5cb270a918b3cd43470966c35bffe55ac4640 Mon Sep 17 00:00:00 2001 From: Alex Ackermann Date: Fri, 18 Jul 2025 09:13:14 +0200 Subject: [PATCH 1/4] fix: add missing quotes to modal titles --- packages/web-pkg/src/components/Modals/SaveAsModal.vue | 4 ++-- .../src/composables/actions/spaces/useSpaceActionsRename.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/web-pkg/src/components/Modals/SaveAsModal.vue b/packages/web-pkg/src/components/Modals/SaveAsModal.vue index 2ac4f2c201..c479b59500 100644 --- a/packages/web-pkg/src/components/Modals/SaveAsModal.vue +++ b/packages/web-pkg/src/components/Modals/SaveAsModal.vue @@ -83,13 +83,13 @@ export default defineComponent({ try { const resource = await saveFile({ destinationFolder, fileName, space }) showMessage({ - title: $gettext('"%{fileName}" was saved successfully', { fileName: resource.name }) + title: $gettext('»%{fileName}« was saved successfully', { fileName: resource.name }) }) openFile({ resource, space, locationQuery }) } catch (e) { console.error(e) showErrorMessage({ - title: $gettext('Unable to save "%{fileName}"', { fileName }), + title: $gettext('Unable to save »%{fileName}«', { fileName }), errors: [e] }) console.error(e) diff --git a/packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRename.ts b/packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRename.ts index a0fac961eb..e766dbbb26 100644 --- a/packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRename.ts +++ b/packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRename.ts @@ -45,7 +45,7 @@ export const useSpaceActionsRename = () => { } dispatchModal({ - title: $gettext('Rename space') + ' ' + resources[0].name, + title: $gettext('Rename space »%{name}«', { name: resources[0].name }), confirmText: $gettext('Rename'), hasInput: true, inputLabel: $gettext('Space name'), From 08449a8892598084df6e95d6bf93a0af346d360f Mon Sep 17 00:00:00 2001 From: Alex Ackermann Date: Fri, 18 Jul 2025 09:25:40 +0200 Subject: [PATCH 2/4] fix more occurences --- .../composables/actions/files/useFileActionsCreateNewFile.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.ts b/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.ts index 114dfe46b6..667e8f1c88 100644 --- a/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.ts +++ b/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.ts @@ -95,7 +95,7 @@ export const useFileActionsCreateNewFile = ({ space }: { space?: Ref Date: Fri, 18 Jul 2025 09:27:19 +0200 Subject: [PATCH 3/4] fix more occurences --- .../composables/actions/files/useFileActionsCreateNewFolder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFolder.ts b/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFolder.ts index bcb33c3c1d..4bd566e873 100644 --- a/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFolder.ts +++ b/packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFolder.ts @@ -36,7 +36,7 @@ export const useFileActionsCreateNewFolder = ({ space }: { space?: Ref Date: Fri, 18 Jul 2025 10:10:27 +0200 Subject: [PATCH 4/4] fix unit tests --- .../actions/files/useFileActionsCreateNewFolder.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCreateNewFolder.spec.ts b/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCreateNewFolder.spec.ts index 7c28b2899c..c9e6b599b5 100644 --- a/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCreateNewFolder.spec.ts +++ b/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCreateNewFolder.spec.ts @@ -36,7 +36,7 @@ describe('useFileActionsCreateNewFolder', () => { expect(upsertResource).toHaveBeenCalled() const { showMessage } = useMessages() - expect(showMessage).toHaveBeenCalledWith({ title: '"myfolder" was created successfully' }) + expect(showMessage).toHaveBeenCalledWith({ title: '»myfolder« was created successfully' }) // expect scrolltoresource to have been called }