Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 8, 2025

Hi all,

This pull request contains a backport of commit 4d696d0d from the openjdk/jdk repository.

The commit being backported was authored by Albert Mingkun Yang on 5 Dec 2025 and was reviewed by Joel Sikström and Thomas Schatzl.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373086 needs maintainer approval

Issue

  • JDK-8373086: Make isexceeded001.java more robust (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/69/head:pull/69
$ git checkout pull/69

Update a local copy of the PR:
$ git checkout pull/69
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/69/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 69

View PR using the GUI difftool:
$ git pr show -t 69

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/69.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4d696d0d0ed523e3c99c68214586673913b1c7b5 8373086: Make isexceeded001.java more robust Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 8, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

@jsikstro
Copy link
Member

jsikstro commented Dec 8, 2025

Just a comment. It's nice that the test is now more robust and as a standalone fix this is fine.

However, we don't expect this to fail in JDK 25, since InitialRAMPercentage is 1.5625 by default in this version. The fix in mainline is necessary since we changed InitialRAMPercentage to 0, making this test fail intermittently because the JVM starts with a really small initial heap.

@sendaoYan
Copy link
Member Author

Just a comment. It's nice that the test is now more robust and as a standalone fix this is fine.

However, we don't expect this to fail in JDK 25, since InitialRAMPercentage is 1.5625 by default in this version. The fix in mainline is necessary since we changed InitialRAMPercentage to 0, making this test fail intermittently because the JVM starts with a really small initial heap.

Yes, test vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded00[1-5]/TestDescription.java was not problemlisted in jdk25u-dev. Sorry for the interrupt.

@sendaoYan sendaoYan closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants