From 89171e859650695ce541c37e11f05a8eccca827e Mon Sep 17 00:00:00 2001 From: janvanrijn Date: Thu, 23 Feb 2023 21:29:42 +0100 Subject: [PATCH 1/2] extends eval engine to work with additional task type active learning --- openml_OS/controllers/Api_splits.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openml_OS/controllers/Api_splits.php b/openml_OS/controllers/Api_splits.php index 033fa4cb9..538b505cb 100644 --- a/openml_OS/controllers/Api_splits.php +++ b/openml_OS/controllers/Api_splits.php @@ -17,7 +17,7 @@ function __construct() { $this->load->helper('file_upload'); $this->db = $this->load->database('read',true); - $this->task_types = array(1, 2, 3, 6, 7, 9); + $this->task_types = array(1, 2, 3, 6, 7, 9, 10); $this->challenge_types = array(9); $this->evaluation = APPPATH . 'third_party/OpenML/Java/evaluate.jar'; $this->eval_engine_config = " -config 'cache_allowed=false;server=".BASE_URL.";api_key=".API_KEY."' "; @@ -135,6 +135,7 @@ function get($task_id) { private function generate($function, $task_id, $filepath) { $task = $this->Task->getById($task_id); + // JvR: in hinge sight, this check belongs in the eval engine, and not here. if ($task === false || in_array($task->ttid, $this->task_types) === false) { http_response_code($this->config->item('general_http_error_code')); die('Task not providing datasplits.'); From a06ac0c070012390ab3f8a99e1e0f7bd494e390c Mon Sep 17 00:00:00 2001 From: janvanrijn Date: Tue, 28 Feb 2023 11:49:58 +0100 Subject: [PATCH 2/2] Update openml_OS/controllers/Api_splits.php thanks for this catch! GitHub should get a Grammerly plugin Co-authored-by: Pieter Gijsbers --- openml_OS/controllers/Api_splits.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openml_OS/controllers/Api_splits.php b/openml_OS/controllers/Api_splits.php index 538b505cb..0027def95 100644 --- a/openml_OS/controllers/Api_splits.php +++ b/openml_OS/controllers/Api_splits.php @@ -135,7 +135,7 @@ function get($task_id) { private function generate($function, $task_id, $filepath) { $task = $this->Task->getById($task_id); - // JvR: in hinge sight, this check belongs in the eval engine, and not here. + // JvR: in hindsight, this check belongs in the eval engine, and not here. if ($task === false || in_array($task->ttid, $this->task_types) === false) { http_response_code($this->config->item('general_http_error_code')); die('Task not providing datasplits.');