From 3bf733260645b8f0e9a4a8d41a9cc51310c822f5 Mon Sep 17 00:00:00 2001 From: Dan Mace Date: Tue, 11 Dec 2018 12:36:30 -0500 Subject: [PATCH 1/2] Add base domain to DNS config Add base domain to the DNS config type. This value is useful to any component which implements DNS management for the cluster. For example, cluster-ingress-operator manages wildcard DNS records for routing within the base domain. --- config/v1/types_dns.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/v1/types_dns.go b/config/v1/types_dns.go index 44fa6e4d27d..c03ba06681b 100644 --- a/config/v1/types_dns.go +++ b/config/v1/types_dns.go @@ -20,6 +20,9 @@ type DNS struct { } type DNSSpec struct { + // BaseDomain is the base domain of the cluster. All managed DNS records will + // be sub-domains of this base. + BaseDomain string `json:"baseDomain"` } type DNSStatus struct { From e3f964095bd83229f964ba3c3185080417b85edc Mon Sep 17 00:00:00 2001 From: Dan Mace Date: Mon, 17 Dec 2018 15:37:53 -0500 Subject: [PATCH 2/2] Improve the BaseDomain docs --- config/v1/types_dns.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/config/v1/types_dns.go b/config/v1/types_dns.go index c03ba06681b..c371895471b 100644 --- a/config/v1/types_dns.go +++ b/config/v1/types_dns.go @@ -20,8 +20,11 @@ type DNS struct { } type DNSSpec struct { - // BaseDomain is the base domain of the cluster. All managed DNS records will + // baseDomain is the base domain of the cluster. All managed DNS records will // be sub-domains of this base. + // + // For example, given the base domain `openshift.example.com`, an API server + // DNS record may be created for `cluster-api.openshift.example.com`. BaseDomain string `json:"baseDomain"` }