From 7571a4f65ad50518c0fd96a69902d445b0d6acb7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bruno=20Barcarol=20Guimar=C3=A3es?= Date: Wed, 26 Apr 2023 12:19:23 +0000 Subject: [PATCH] test/e2e: relax pending test check This test is meant to cause a pending timeout using a non-existent image. It works as intended, but it intentionally uses a short timeout period so that it executes quickly. It may happen that the timeout happens for other reasons (this is after all what the actual verification is meant to detect), leading to test failures such as the one seen here: https://github.com/openshift/ci-tools/pull/3390#issuecomment-1520443642 Since the reason for the delay is not relevant for this test, only that it be detected and properly reported, this change relaxes the error message searched in the logs such that any pending situation satisfies the test. --- test/e2e/multi-stage/e2e_test.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/test/e2e/multi-stage/e2e_test.go b/test/e2e/multi-stage/e2e_test.go index 7b32ca3807a..ac0c4b37db9 100644 --- a/test/e2e/multi-stage/e2e_test.go +++ b/test/e2e/multi-stage/e2e_test.go @@ -211,11 +211,8 @@ func TestMultiStage(t *testing.T) { "--unresolved-config", "config.yaml", "--target", "pending", }, - env: []string{defaultJobSpec}, - output: []string{ - `pod pending for more than 30s: container \"test\" has not started in`, - "Error: ErrImagePull", - }, + env: []string{defaultJobSpec}, + output: []string{`pod pending for more than 30s:`}, }, }