diff --git a/pkg/controller/prpqr_reconciler/prpqr_reconciler.go b/pkg/controller/prpqr_reconciler/prpqr_reconciler.go index 273c4c0f01b..76f63c23b67 100644 --- a/pkg/controller/prpqr_reconciler/prpqr_reconciler.go +++ b/pkg/controller/prpqr_reconciler/prpqr_reconciler.go @@ -48,9 +48,10 @@ const ( conditionAllJobsTriggered = "AllJobsTriggered" conditionWithErrors = "WithErrors" - aggregationIDLabel = "release.openshift.io/aggregation-id" - defaultAggregatorJobTimeout = 6 * time.Hour - defaultMultiRefJobTimeout = 6 * time.Hour + aggregationIDLabel = "release.openshift.io/aggregation-id" + // TODO: temporarily increase timeout to allow payload tests to run during k8s rebase + defaultAggregatorJobTimeout = 8 * time.Hour + defaultMultiRefJobTimeout = 8 * time.Hour dependentProwJobsFinalizer = "pullrequestpayloadqualificationruns.ci.openshift.io/dependent-prowjobs" ) @@ -628,6 +629,11 @@ func generateProwjob(ciopConfig *api.ReleaseBuildConfiguration, options.Cron = "@yearly" }) periodic.Name = generateJobNameToSubmit(inject, prs) + // TODO: temporarily increase timeout to allow payload tests to run during k8s rebase + if periodic.DecorationConfig == nil { + periodic.DecorationConfig = &prowv1.DecorationConfig{} + } + periodic.DecorationConfig.Timeout = &prowv1.Duration{Duration: 6 * time.Hour} break } // We did not find the injected test: this is a bug diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml index c0b44c338be..c05ed37075a 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml @@ -21,7 +21,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true - timeout: 6h0m0s + timeout: 8h0m0s job: aggregator-periodic-ci-test-org-test-repo-test-branch-test-name pod_spec: containers: @@ -120,6 +120,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" @@ -205,6 +206,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case_with_scheduling.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case_with_scheduling.yaml index dc66a10b2ca..81ba40f3e99 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case_with_scheduling.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case_with_scheduling.yaml @@ -21,7 +21,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true - timeout: 6h0m0s + timeout: 8h0m0s job: aggregator-periodic-ci-test-org-test-repo-test-branch-test-name pod_spec: containers: @@ -120,6 +120,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" @@ -205,6 +206,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case.yaml index d3f8a88fbdc..59b7df51dbf 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_cluster_override.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_cluster_override.yaml index 731901042de..0d298ff17ba 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_cluster_override.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_cluster_override.yaml @@ -25,7 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true - timeout: 6h0m0s + timeout: 8h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_metal_override.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_metal_override.yaml index 1311373695b..ba48bf51c45 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_metal_override.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_metal_override.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_scheduling.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_scheduling.yaml index 88dba4aee7f..2f871d9c661 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_scheduling.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_scheduling.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_variant.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_variant.yaml index 7eecf84a2f4..89884523e5e 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_variant.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_variant.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_vsphere_override.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_vsphere_override.yaml index fbef9484577..3916309c39c 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_vsphere_override.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_vsphere_override.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_without_PR__testing_specified_base.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_without_PR__testing_specified_base.yaml index ef3878b0473..cb5cd750352 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_without_PR__testing_specified_base.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_without_PR__testing_specified_base.yaml @@ -24,6 +24,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_case__one_of_the_prowjobs_already_exists.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_case__one_of_the_prowjobs_already_exists.yaml index 9366ba11dbd..b6f91b41458 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_case__one_of_the_prowjobs_already_exists.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_case__one_of_the_prowjobs_already_exists.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_override_initial_and_base_payload_pullspecs.yaml b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_override_initial_and_base_payload_pullspecs.yaml index a8776a7654f..3586af7eeb8 100644 --- a/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_override_initial_and_base_payload_pullspecs.yaml +++ b/pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_override_initial_and_base_payload_pullspecs.yaml @@ -25,6 +25,7 @@ cluster: cluster-name-overwritten decoration_config: skip_cloning: true + timeout: 6h0m0s extra_refs: - base_ref: test-branch base_sha: "123456" diff --git a/pkg/jobrunaggregator/jobrunaggregatoranalyzer/analyzer.go b/pkg/jobrunaggregator/jobrunaggregatoranalyzer/analyzer.go index 20fd37170e6..d29055120d3 100644 --- a/pkg/jobrunaggregator/jobrunaggregatoranalyzer/analyzer.go +++ b/pkg/jobrunaggregator/jobrunaggregatoranalyzer/analyzer.go @@ -108,8 +108,9 @@ func (o *JobRunAggregatorAnalyzerOptions) Run(ctx context.Context) error { // the aggregator has a long time. The jobs it aggregates only have 4h (we think). durationToWait := o.timeout - 20*time.Minute - if durationToWait > (5*time.Hour + 15*time.Minute) { - durationToWait = 5*time.Hour + 15*time.Minute + // TODO: temporary time change for payload testing during k8s rebase + if durationToWait > (7*time.Hour + 15*time.Minute) { + durationToWait = 7*time.Hour + 15*time.Minute } timeToStopWaiting := o.jobRunStartEstimate.Add(durationToWait) alog := logrus.WithFields(logrus.Fields{