From e3e1a49c6247b54b4631fce364015350b3fa17c1 Mon Sep 17 00:00:00 2001 From: Abhinav Dahiya Date: Fri, 5 Oct 2018 15:36:32 -0700 Subject: [PATCH] genric_handler: error when object has no name --- pkg/cvo/internal/generic.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/cvo/internal/generic.go b/pkg/cvo/internal/generic.go index d20175c2a0..f015c4f112 100644 --- a/pkg/cvo/internal/generic.go +++ b/pkg/cvo/internal/generic.go @@ -2,6 +2,7 @@ package internal import ( "encoding/json" + "fmt" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" @@ -28,6 +29,9 @@ func readUnstructuredV1OrDie(objBytes []byte) *unstructured.Unstructured { } func applyUnstructured(client dynamic.ResourceInterface, required *unstructured.Unstructured) (*unstructured.Unstructured, bool, error) { + if required.GetName() == "" { + return nil, false, fmt.Errorf("invalid object: name cannot be empty") + } existing, err := client.Get(required.GetName(), metav1.GetOptions{}) if apierrors.IsNotFound(err) { actual, err := client.Create(required)