From 06ef64e52fa3ee07775916781ed904a951611710 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Thu, 23 Feb 2023 09:43:48 -0800 Subject: [PATCH] pkg/cvo/status: Failing is not more serious than Degraded The outgoing text goes way back to the local Failing type in 7f5b7f42dd (conditions: Use a consistent constant for the Failing condition, 2019-05-19, #191). But ClusterVersion doesn't include Degraded, and ClusterOperator don't set Failing, so we don't need a relative-seriousness ranking. In practice, a Degraded=True ClusterOperator is one of several issues that could lead to a Failing=True ClusterVersion, and when that's the only issue going on, they clearly have the same severity. When an Available=False ClusterOperator feeds a Failing=True ClusterVersion, that would be worse than a Degraded=True Available=True ClusterOperator. And there may also be issues like the CVO failing to reconcile a peripheral change like an alert rule where ClusterVersion is Failing=True despite the issue being less severe than many Degraded=True ClusterOperator situations. --- pkg/cvo/status.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/cvo/status.go b/pkg/cvo/status.go index e162316990..554d455108 100644 --- a/pkg/cvo/status.go +++ b/pkg/cvo/status.go @@ -27,8 +27,7 @@ import ( const ( // ClusterStatusFailing is set on the ClusterVersion status when a cluster - // cannot reach the desired state. It is considered more serious than Degraded - // and indicates the cluster is not healthy. + // cannot reach the desired state. It indicates the cluster is not healthy. ClusterStatusFailing = configv1.ClusterStatusConditionType("Failing") // MaxHistory is the maximum size of ClusterVersion history. Once exceeded