Skip to content

Commit 49779c3

Browse files
committed
OWNERS: Configure Prow with approver and reviewer information
Most of the folks I've listed here are under Aaron in Red Hat, with Yifan being the installer lead. I've also included Alex and Clayton, who are higher up in Red Hat but still members of @openshift/installer. I'm guessing about roles, but we can always adjust later as we see fit. Approvers can also /lgtm [1], so there's no need to list them under 'reviewers' as well. The docs link in OWNERS is from [2]. While updating CONTRIBUTING.md to mention OWNERS (using wording based on [3]), I've also: * Added a line to make it clear that filing issues is helpful to (for folks who don't have the time or inclination to work up a PR). * Turned the unordered list into an ordered list. These entries happen sequentially, and an ordered list makes that more obvious. * Made "below" a link, to make finding the referenced content more convenient. * Shuffled words in the commit message format title to make it shorter. The references to 'make structure-check' are stale since d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), but I've left fixing that to follow-up work. [1]: https://github.com/kubernetes/community/blob/4c0c2e9e659d2f989f3d23c3634c16bb099f3064/contributors/guide/owners.md#quirks-of-the-process [2]: kubernetes/kubernetes-template-project#15 [3]: https://github.com/kubernetes/kubernetes-template-project/blame/16f1588e6d4746876beb08cc64769657530d4872/CONTRIBUTING.md#L10
1 parent e8a005e commit 49779c3

File tree

2 files changed

+26
-11
lines changed

2 files changed

+26
-11
lines changed

CONTRIBUTING.md

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,21 @@ Due to their public nature, GitHub and mailing lists are not appropriate places
3939

4040
### Contribution Flow
4141

42-
This is a rough outline of what a contributor's workflow looks like:
43-
44-
- Create a topic branch from where you want to base your work (usually master).
45-
- Make commits of logical units.
46-
- Make sure your commit messages are in the proper format (see below).
47-
- Push your changes to a topic branch in your fork of the repository.
48-
- Make sure the tests pass, and add any new tests as appropriate.
49-
- Please run this command before submitting your pull request:
42+
Anyone may [file issues][new-issue].
43+
For contributors who want to work up pull requests, the workflow is roughly:
44+
45+
1. Create a topic branch from where you want to base your work (usually master).
46+
2. Make commits of logical units.
47+
3. Make sure your commit messages are in the proper format (see [below](#commit-message-format)).
48+
4. Push your changes to a topic branch in your fork of the repository.
49+
5. Make sure the tests pass, and add any new tests as appropriate.
50+
6. Please run this command before submitting your pull request:
5051
```sh
5152
make structure-check
5253
```
53-
- Note that a portion of the docs and examples are generated and that the generated files are to be committed by you. `make structure-check` checks that what is generated is what you must commit.
54-
- Submit a pull request to the original repository.
54+
Note that a portion of the docs and examples are generated and that the generated files are to be committed by you. `make structure-check` checks that what is generated is what you must commit.
55+
7. Submit a pull request to the original repository.
56+
8. The [repo owners](OWNERS) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].
5557

5658
Thanks for your contributions!
5759

@@ -63,7 +65,7 @@ Tectonic Installer includes syntax checks on the Terraform templates which will
6365

6466
Use `make structure-check` to identify files that don't meet the canonical format and style. Then, use `terraform fmt` to align the template syntax, if necessary.
6567
66-
## Format of the Commit Message
68+
## Commit Message Format
6769
6870
We follow a rough convention for commit messages that is designed to answer two
6971
questions: what changed and why. The subject line should feature the what and
@@ -98,3 +100,5 @@ git tools.
98100
[tf-doc]: https://www.terraform.io/docs/index.html
99101
[golang-style]: https://github.com/golang/go/wiki/CodeReviewComments
100102
[disclosure]: https://coreos.com/security/disclosure/
103+
[new-issue]: https://github.com/openshift/installer/issues/new
104+
[prow-review]: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process

OWNERS

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
2+
3+
approvers:
4+
- aaronlevey
5+
- crawford
6+
- smarterclayton
7+
- yifan-gu
8+
reviewers:
9+
- abhinavdahiya
10+
- vikramsk
11+
- wking

0 commit comments

Comments
 (0)