Skip to content

Commit 62f87ac

Browse files
committed
OWNERS_ALIASES: Define aliases for reviewers and approvers
This will make it easier to add special-case OWNERS files to openshift/release while still getting the members slurped up with the populate-owners tooling. That tooling pulls OWNERS_ALIASES since openshift/release@e1f993fb (populate-owners: Also slurp OWNERS_ALIASES, 2018-08-25, openshift/release#1285).
1 parent f941341 commit 62f87ac

File tree

5 files changed

+18
-10
lines changed

5 files changed

+18
-10
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Before creating your PR, please make sure to add the appropriate GitHub label; i.e. `run-smoke-tests`. For more details see
22
[tests/README.md](../tests/README.md).
33

4-
(In case you don't have permissions to add labels, please ask a [maintainer](../OWNERS).)
4+
(In case you don't have permissions to add labels, please ask [a](../OWNERS) [maintainer](../OWNERS_ALIASES).)

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ For contributors who want to work up pull requests, the workflow is roughly:
4444
```
4545
Note that a portion of the docs and examples are generated and that the generated files are to be committed by you. `make structure-check` checks that what is generated is what you must commit.
4646
7. Submit a pull request to the original repository.
47-
8. The [repo owners](OWNERS) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].
47+
8. The [repo](OWNERS) [owners](OWNERS_ALIASES) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].
4848

4949
Thanks for your contributions!
5050

OWNERS

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
2+
# This file just uses aliases defined in OWNERS_ALIASES.
23

34
approvers:
4-
- aaronlevy
5-
- abhinavdahiya
6-
- crawford
7-
- smarterclayton
8-
- wking
9-
- yifan-gu
5+
- installer-approvers
106
reviewers:
11-
- vikramsk
7+
- installer-reviewers

OWNERS_ALIASES

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES
2+
3+
aliases:
4+
installer-approvers:
5+
- aaronlevy
6+
- abhinavdahiya
7+
- crawford
8+
- smarterclayton
9+
- wking
10+
- yifan-gu
11+
installer-reviewers:
12+
- vikramsk

tests/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ In addition to our basic set of tests we have smoke tests which are running on A
2525
### FAQ
2626
- *I am not able to add labels, what should I do?*
2727

28-
Please ask one of [the repository maintainers](../OWNERS) to add the
28+
Please ask one of the [repository](../OWNERS) [maintainers](../OWNERS_ALIASES) to add the
2929
labels.
3030

3131
- *How do I retrigger the tests?*

0 commit comments

Comments
 (0)