Skip to content

Commit 8ff1cee

Browse files
committed
hack/yaml-lint: No-op this script
Temporarily make the script a no-op while we work out whether we want to keep this. It's currently complaining about the YAML output from Glide in the previous commit [1]: ./glide.yaml 1:1 warning missing document start "---" (document-start) 3:1 error wrong indentation: expected 2 but found 0 (indentation) 5:1 error wrong indentation: expected 2 but found 0 (indentation) 38:1 error wrong indentation: expected 2 but found 0 (indentation) Dropping the script entirely would break CI [2]. Alex is ok dropping yamllint entirely, but I'm half-interested in keeping it around in case we decide to move any static YAML assets (e.g. pkg/asset/manifests/content/tectonic/rbac/role-user.go) over into data/data. [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/370/pull-ci-openshift-installer-yaml-lint/636/build-log.txt [2]: https://github.com/openshift/release/blob/d7ea5b36da63140fbb99c293aadde3bb279a24f9/ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml#L354
1 parent 1010077 commit 8ff1cee

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ For contributors who want to work up pull requests, the workflow is roughly:
4242
hack/shellcheck.sh
4343
hack/tf-fmt.sh -list -check
4444
hack/tf-lint.sh
45-
hack/yaml-lint.sh
4645
```
4746
7. Submit a pull request to the original repository.
4847
8. The [repo](OWNERS) [owners](OWNERS_ALIASES) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].

hack/yaml-lint.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/bin/sh
2+
exit 0 # temporarily disable while we work out whether to drop this
23
if [ "$IS_CONTAINER" != "" ]; then
34
yamllint --config-data "{extends: default, rules: {line-length: {level: warning, max: 120}}}" .
45
else

0 commit comments

Comments
 (0)