From 23f2d6a2d6bc803bebf7e1559fa349e7f89d62c8 Mon Sep 17 00:00:00 2001 From: Knative Prow Robot Date: Tue, 9 Mar 2021 15:25:25 -0800 Subject: [PATCH] Add immutable fields validation to v1beta1 broker (#5028) Co-authored-by: Yi Zhang --- pkg/apis/eventing/v1beta1/broker_validation.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/apis/eventing/v1beta1/broker_validation.go b/pkg/apis/eventing/v1beta1/broker_validation.go index 7f408c48829..e77d209481d 100644 --- a/pkg/apis/eventing/v1beta1/broker_validation.go +++ b/pkg/apis/eventing/v1beta1/broker_validation.go @@ -36,7 +36,13 @@ func (b *Broker) Validate(ctx context.Context) *apis.FieldError { errs = errs.Also(apis.ErrMissingField(BrokerClassAnnotationKey)) } - return errs.Also(b.Spec.Validate(withNS).ViaField("spec")) + errs = errs.Also(b.Spec.Validate(withNS).ViaField("spec")) + + if apis.IsInUpdate(ctx) { + original := apis.GetBaseline(ctx).(*Broker) + errs = errs.Also(b.CheckImmutableFields(ctx, original)) + } + return errs } func (bs *BrokerSpec) Validate(ctx context.Context) *apis.FieldError {