From 0c787792a8397fb524346c06082104e8793934f5 Mon Sep 17 00:00:00 2001 From: Stavros Kontopoulos Date: Fri, 4 Jun 2021 13:48:30 +0300 Subject: [PATCH] mute noisy metrics --- openshift/patches/020-mutemetrics.patch | 30 +++++++++++++++++++ .../pkg/controller/stats_reporter.go | 4 +-- .../knative.dev/pkg/webhook/stats_reporter.go | 5 ++-- 3 files changed, 34 insertions(+), 5 deletions(-) create mode 100644 openshift/patches/020-mutemetrics.patch diff --git a/openshift/patches/020-mutemetrics.patch b/openshift/patches/020-mutemetrics.patch new file mode 100644 index 00000000000..8998b1685ae --- /dev/null +++ b/openshift/patches/020-mutemetrics.patch @@ -0,0 +1,30 @@ +diff --git a/vendor/knative.dev/pkg/controller/stats_reporter.go b/vendor/knative.dev/pkg/controller/stats_reporter.go +index 6735285db..e1912daab 100644 +--- a/vendor/knative.dev/pkg/controller/stats_reporter.go ++++ b/vendor/knative.dev/pkg/controller/stats_reporter.go +@@ -199,7 +199,7 @@ func (r *reporter) ReportReconcile(duration time.Duration, success string, key t + return err + } + +- metrics.RecordBatch(ctx, reconcileCountStat.M(1), +- reconcileLatencyStat.M(duration.Milliseconds())) ++ // TODO skonto: fix latency histogram ++ metrics.RecordBatch(ctx, reconcileCountStat.M(1)) + return nil + } +diff --git a/vendor/knative.dev/pkg/webhook/stats_reporter.go b/vendor/knative.dev/pkg/webhook/stats_reporter.go +index 9d64634fe..d2845ac96 100644 +--- a/vendor/knative.dev/pkg/webhook/stats_reporter.go ++++ b/vendor/knative.dev/pkg/webhook/stats_reporter.go +@@ -99,9 +99,8 @@ func (r *reporter) ReportRequest(req *admissionv1.AdmissionRequest, resp *admiss + return err + } + +- metrics.RecordBatch(ctx, requestCountM.M(1), +- // Convert time.Duration in nanoseconds to milliseconds +- responseTimeInMsecM.M(float64(d.Milliseconds()))) ++ // TODO skonto: fix latency histogram ++ metrics.Record(ctx, requestCountM.M(1)) + return nil + } + diff --git a/vendor/knative.dev/pkg/controller/stats_reporter.go b/vendor/knative.dev/pkg/controller/stats_reporter.go index 474bab3fc61..dbf74d6007c 100644 --- a/vendor/knative.dev/pkg/controller/stats_reporter.go +++ b/vendor/knative.dev/pkg/controller/stats_reporter.go @@ -197,7 +197,7 @@ func (r *reporter) ReportReconcile(duration time.Duration, success string, key t return err } - metrics.RecordBatch(ctx, reconcileCountStat.M(1), - reconcileLatencyStat.M(duration.Milliseconds())) + // TODO skonto: fix latency histogram + metrics.RecordBatch(ctx, reconcileCountStat.M(1)) return nil } diff --git a/vendor/knative.dev/pkg/webhook/stats_reporter.go b/vendor/knative.dev/pkg/webhook/stats_reporter.go index 9d64634feae..d2845ac9602 100644 --- a/vendor/knative.dev/pkg/webhook/stats_reporter.go +++ b/vendor/knative.dev/pkg/webhook/stats_reporter.go @@ -99,9 +99,8 @@ func (r *reporter) ReportRequest(req *admissionv1.AdmissionRequest, resp *admiss return err } - metrics.RecordBatch(ctx, requestCountM.M(1), - // Convert time.Duration in nanoseconds to milliseconds - responseTimeInMsecM.M(float64(d.Milliseconds()))) + // TODO skonto: fix latency histogram + metrics.Record(ctx, requestCountM.M(1)) return nil }