From b5eb6675c0664cb8dbb93e9e464b6a165bbf6e5f Mon Sep 17 00:00:00 2001 From: Chris Suszynski Date: Fri, 30 Oct 2020 16:22:35 +0100 Subject: [PATCH] Reduce a test name length to prevent DNS label too long error (#4442) Having too long namespace or kservice name can lead to an error like: ``` $ host wathola-receiver-test-continuous-events-propagation-with-prober-zxmkp.apps.example.org host: 'wathola-receiver-test-continuous-events-propagation-with-prober-zxmkp.apps.example.org' is not a legal IDN name (domain label longer than 63 characters), use +noidnin ``` In this case my namespace is test-continuous-events-propagation-with-prober-zxmkp and knative service name is wathola-receiver. The namespace is taken from Go test method name. The limit is 63 characters. In this example the subdomain is 69 characters. This does affect OpenShift Serverless as kservices there have a URL format of `${ksvc.name}-${ksvc.namespace}` to enable usage of TLS wildcard certificates. Reducing this test method name length will help fit within this strict limit of 63 chars. --- test/upgrade/probe_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/upgrade/probe_test.go b/test/upgrade/probe_test.go index e884ee0e045..ab01a93db47 100644 --- a/test/upgrade/probe_test.go +++ b/test/upgrade/probe_test.go @@ -34,7 +34,7 @@ const ( readyMessage = "prober ready" ) -func TestContinuousEventsPropagationWithProber(t *testing.T) { +func TestEventsPropagationWithProber(t *testing.T) { // We run the prober as a golang test because it fits in nicely with // the rest of our integration tests, and AssertProberDefault needs // a *testing.T. Unfortunately, "go test" intercepts signals, so we