From 11d3dd2c11484cc2f91aaa74226d6747206637ac Mon Sep 17 00:00:00 2001 From: Patryk Matuszak Date: Thu, 18 Apr 2024 12:05:18 +0200 Subject: [PATCH 1/5] Enable RHOCP for beta RHEL --- scripts/devenv-builder/configure-vm.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/devenv-builder/configure-vm.sh b/scripts/devenv-builder/configure-vm.sh index c8881c8b11..dc65862f1b 100755 --- a/scripts/devenv-builder/configure-vm.sh +++ b/scripts/devenv-builder/configure-vm.sh @@ -181,9 +181,11 @@ if ${RHEL_SUBSCRIPTION}; then OSVERSION=$(awk -F: '{print $5}' /etc/system-release-cpe) sudo subscription-manager config --rhsm.manage_repos=1 + sudo subscription-manager repos \ + --enable "rhocp-${OCPVERSION}-for-rhel-${OSVERSION}-$(uname -m)-rpms" + if ! ${RHEL_BETA_VERSION} ; then sudo subscription-manager repos \ - --enable "rhocp-${OCPVERSION}-for-rhel-${OSVERSION}-$(uname -m)-rpms" \ --enable "fast-datapath-for-rhel-${OSVERSION}-$(uname -m)-rpms" else OCP_REPO_NAME="rhocp-${OCPVERSION}-for-rhel-${OSVERSION}-mirrorbeta-$(uname -i)-rpms" From 3665510db7d8d5326ee7eaada0985748d6a6fc83 Mon Sep 17 00:00:00 2001 From: Patryk Matuszak Date: Thu, 18 Apr 2024 12:58:08 +0200 Subject: [PATCH 2/5] When selecting compose ID select only valid line --- test/bin/build_images.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/bin/build_images.sh b/test/bin/build_images.sh index d8db45fedb..22be01bfd2 100755 --- a/test/bin/build_images.sh +++ b/test/bin/build_images.sh @@ -354,7 +354,7 @@ do_group() { rc=$? set -e if [[ "${rc}" -eq 0 ]]; then - buildid=$(echo "${build_cmd_output}" | awk '{print $2}') + buildid=$(echo "${build_cmd_output}" | awk '/^Compose/ {print $2}') break fi sleep 15 From 83ea9d2a2feb61a84ef626509c78a1e588331265 Mon Sep 17 00:00:00 2001 From: Patryk Matuszak Date: Thu, 18 Apr 2024 13:34:50 +0200 Subject: [PATCH 3/5] Check if wait_images.py returned right amount of IDs --- test/bin/build_images.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/bin/build_images.sh b/test/bin/build_images.sh index 22be01bfd2..b385b612d1 100755 --- a/test/bin/build_images.sh +++ b/test/bin/build_images.sh @@ -473,6 +473,12 @@ do_group() { builds_to_get=$(time "${SCRIPTDIR}/wait_images.py" "${buildid_list[@]}") fi + builds_to_get_num="$(echo "${builds_to_get}" | awk -F' ' '{print NF}')" + if [ "${#buildid_list[@]}" -ne "${builds_to_get_num}" ]; then + echo "wait_images.py returned unexpected amount of build IDs" + return 1 + fi + echo "Downloading build logs, metadata, and image" cd "${IMAGEDIR}/builds" From 737a704466a8cfde9c37840b961b77de9b7e446b Mon Sep 17 00:00:00 2001 From: Patryk Matuszak Date: Thu, 18 Apr 2024 14:31:14 +0200 Subject: [PATCH 4/5] Return 1 if aliasing failed --- test/bin/build_images.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/bin/build_images.sh b/test/bin/build_images.sh index b385b612d1..8cf5b90e0a 100755 --- a/test/bin/build_images.sh +++ b/test/bin/build_images.sh @@ -552,6 +552,7 @@ do_group() { record_junit "${groupdir}" "${alias_name}" "alias" "OK" else record_junit "${groupdir}" "${alias_name}" "alias" "FAILED" + return 1 fi done From c636c8b07c032aad7bbab3dd738fb530a9ef1b6f Mon Sep 17 00:00:00 2001 From: Patryk Matuszak Date: Fri, 19 Apr 2024 11:11:55 +0200 Subject: [PATCH 5/5] Give composer some time to be ready for workers --- scripts/image-builder/cleanup.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/scripts/image-builder/cleanup.sh b/scripts/image-builder/cleanup.sh index 204f0cca41..197745632d 100755 --- a/scripts/image-builder/cleanup.sh +++ b/scripts/image-builder/cleanup.sh @@ -82,7 +82,16 @@ restart_osbuilder_services() { if ! systemctl is-active -q osbuild-composer.socket &>/dev/null ; then title "Starting osbuild services" sudo systemctl start osbuild-composer.socket - sudo systemctl start osbuild-worker@1.service + for try in $(seq 3); do + sleep 1 # Give composer some time to be ready for workers + if sudo systemctl start osbuild-worker@1.service; then + break + else + if [ "${try}" -eq 2 ]; then + return 1 + fi + fi + done fi }