From 8d9f5f5810d79f2f7f6d436bf6d95e20c0d4d910 Mon Sep 17 00:00:00 2001
From: Sachin Singla <ssingla@redhat.com>
Date: Tue, 24 Sep 2024 14:36:22 +0530
Subject: [PATCH] OADP-3562: Fix controller panic on secret key-value parsing

---
 .golangci.yaml          | 1 +
 controllers/registry.go | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.golangci.yaml b/.golangci.yaml
index 71c6cf89c82..4d0187a6411 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -94,6 +94,7 @@ linters:
     # - gosimple
     # - govet
     # - ineffassign
+    - loggercheck
     # - misspell
     - nakedret
     # - nilerr
diff --git a/controllers/registry.go b/controllers/registry.go
index 1f5d98c0d31..3234cd53a13 100644
--- a/controllers/registry.go
+++ b/controllers/registry.go
@@ -472,8 +472,8 @@ func (r *DPAReconciler) getMatchedKeyValue(key string, s string) (string, error)
 		s = strings.TrimPrefix(s, prefix)
 	}
 	if len(s) == 0 {
-		r.Log.Info("Could not parse secret for %s", key)
-		return s, errors.New(key + " secret parsing error")
+		r.Log.Info(fmt.Sprintf("Could not parse secret for %s", key))
+		return s, errors.New("secret parsing error in key " + key)
 	}
 	return s, nil
 }